ICEfaces
  1. ICEfaces
  2. ICE-9420

ACE Component ThemeRoller theme compliance issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3.x, ACE components
    • Assignee Priority:
      P1
    • Affects:
      Compatibility/Configuration

      Description

      Many of the ACE components do not adhere completely to the ThemeRoller theme standards. This JIRA is to clean-up any straggler issues that remain.

      Per-Component Issues:

      ace:accordion
      X Missing bottom header border ("Smoothness")

      ace:dataTable
      X row selection either missing top border or shouldn't have borders at all?
      X Missing rounded borders on header, but they are there on footer.
      X Col Grouping doesn't use themeroller styles for group summary rows
          - app controlled - no appropriate theme roller style
      X incorrect selected row styling / color?
          - in comparison to primefaces - pf is wrong

      ace:dialog
      X close X button incorrectly styled

      ace:menu (s)
      X missing hover/highlight borders (?)
         - left as is, none of wijmo samples show borders in hover/highlight items; trying to change that causes all items in default state to have borders as well, making menus not look appealing
      X missing popup shadows
         - added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)

      ace:autoCompleteEntry / ace:comboBox
      X Incorrect hover/highlight styling
         - looks fine to me
      X incorrect popup list font styling (size)
         - both are font-size 13px - difference is an illusion

      ace:tableConfigPanel
      X Not using themeroller background styling for body of panel.

      ace:dateTimeEntry
      X showcase Overview, header is too tall vs. popup which is correct.
          - fixed by jqui css backport

      ace:list
      X incorrect row/element default styling, selection styling
         - same styling as table, recommended classes from JQUI

      ace:panel
      X menu icon has incorrect padding on right/left side ("south-street")
         - fixed by removing showcase specific style hacks

      ace:selectMenu
      X Missing list highlight rounded borders

      ace:tabSet
      X Incorrect label font styling
         - looks fine to me
      X Incorrect bottom border on selected tab (shouldn't have one)
         - this is a change in JQUI 1.9 - we need to upgrade
      X Missing mouse hover styling
         - was removed from component as optimization? YUI / JQUI normally have hover eventing

      ace:tooltip
      X Incorrect tooltip border styling/shadowing
         - added drop shadow rule
      X Incorrect tooltip text styling
         - font-size was defined by tooltip theme, now inherited

      ace:tree
      X Incorrect none-rounded highlight/selected styling
         - item with rounded corners doesn't look good floating in a tree with no other rounded corners
         - tiny items like this don't look good with rounded corners
         - would need to increase padding

        Activity

        Hide
        Chris Hesse added a comment - - edited

        I was asking for help in the forum on this, but no answers...

        All of the CSS/Theme issues mentioned are due to the fact that the resource-dependency.xml includes the theme roller themes in 3.3 (did not in 3.2), and it makes the CSS files load out of order.

        http://www.icesoft.org/JForum/posts/list/22089.page#sthash.ee5A0Rqe.dpbs

        Isn't this an ordering issue? The reason that the same theme, downloaded from themeroller (say cupertino), does NOT have the issues identified here, is because it is NOT in the dependency-xml, and therefore "theme.css" from a custom theme "wins" as it is loaded last. The built in themes are higher up the chain and therefore show all of these issues. I hope I'm not being a burden, I'm just trying to be of help. Is there a reason why this isn't the root cause of all of these issues?

        Show
        Chris Hesse added a comment - - edited I was asking for help in the forum on this, but no answers... All of the CSS/Theme issues mentioned are due to the fact that the resource-dependency.xml includes the theme roller themes in 3.3 (did not in 3.2), and it makes the CSS files load out of order. http://www.icesoft.org/JForum/posts/list/22089.page#sthash.ee5A0Rqe.dpbs Isn't this an ordering issue? The reason that the same theme, downloaded from themeroller (say cupertino), does NOT have the issues identified here, is because it is NOT in the dependency-xml, and therefore "theme.css" from a custom theme "wins" as it is loaded last. The built in themes are higher up the chain and therefore show all of these issues. I hope I'm not being a burden, I'm just trying to be of help. Is there a reason why this isn't the root cause of all of these issues?
        Hide
        Nils Lundquist added a comment - - edited

        Accordion bottom header fixed:
        Revision #36978
        Committed by nils.lundquist
        Yesterday 3:56 PM
        ICE-9420 - Removed accordion border hiding and extraneous positioning rules.

        Base CSS ordering fixed:
        Revision #36999
        Committed by nils.lundquist
        4 minutes ago
        ICE-9420 - Ensure theme css dynamically merged after compile-time merged base css.

        • resolves accordion border issue
        • resolves dialog button themeing issue
        • add menu highlight borders
        Show
        Nils Lundquist added a comment - - edited Accordion bottom header fixed: Revision #36978 Committed by nils.lundquist Yesterday 3:56 PM ICE-9420 - Removed accordion border hiding and extraneous positioning rules. Base CSS ordering fixed: Revision #36999 Committed by nils.lundquist 4 minutes ago ICE-9420 - Ensure theme css dynamically merged after compile-time merged base css. resolves accordion border issue resolves dialog button themeing issue add menu highlight borders
        Hide
        Nils Lundquist added a comment -

        Revision #37000
        Committed by nils.lundquist
        Moments ago
        ICE-9420 - Fixed ace:tableConfigPanel cell backgrounds

        Show
        Nils Lundquist added a comment - Revision #37000 Committed by nils.lundquist Moments ago ICE-9420 - Fixed ace:tableConfigPanel cell backgrounds
        Hide
        Nils Lundquist added a comment -
        Show
        Nils Lundquist added a comment - row selection either missing top border or shouldn't have borders at all? must maintain borders to maintain alignment during hover / selection unavoidable issue with borders is due to collapsed table borders http://stackoverflow.com/questions/1241757/applying-borders-to-a-single-table-cell-when-using-border-collapse
        Hide
        Nils Lundquist added a comment - - edited
        • Missing rounded borders on header, but they are there on footer.
        • scrollable footer has no rounded corners. removing rounded corners from paginator and non-scrollable footer for consistency.

        Revision #37006
        Committed by nils.lundquist
        Moments ago
        ICE-9420 - Removed datatable rounded corners. (Paginator or when head or footer are defined with a facet)

        Show
        Nils Lundquist added a comment - - edited Missing rounded borders on header, but they are there on footer. scrollable footer has no rounded corners. removing rounded corners from paginator and non-scrollable footer for consistency. Revision #37006 Committed by nils.lundquist Moments ago ICE-9420 - Removed datatable rounded corners. (Paginator or when head or footer are defined with a facet)
        Hide
        Cruz Miraback added a comment - - edited

        ICEfaces3/trunk revision# 37049
        ConfirmationDialog: The component is taking up space within the body of the page when it is rendered, and the styling is incorrect (last known working revision is 37033).

        Show
        Cruz Miraback added a comment - - edited ICEfaces3/trunk revision# 37049 ConfirmationDialog: The component is taking up space within the body of the page when it is rendered, and the styling is incorrect (last known working revision is 37033).
        Hide
        Ken Fyten added a comment -

        New regression failure reported on showcase with rvn#37217:

        showcase (Firefox21):
        selectMenu > Required Styling:
        Changing the colours of the required/optional fields has no effect. They remain as the default colours regardless of what is selected.

        Show
        Ken Fyten added a comment - New regression failure reported on showcase with rvn#37217: showcase (Firefox21): selectMenu > Required Styling: Changing the colours of the required/optional fields has no effect. They remain as the default colours regardless of what is selected.
        Hide
        Nils Lundquist added a comment -

        regression resolved - missing space character in style class rendering

        Show
        Nils Lundquist added a comment - regression resolved - missing space character in style class rendering
        Hide
        Nils Lundquist added a comment -

        All style issue addressed.

        Show
        Nils Lundquist added a comment - All style issue addressed.

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: