Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 3.3
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ICEfaces 3.x, ACE components
-
Assignee Priority:P1
-
Affects:Compatibility/Configuration
Description
Many of the ACE components do not adhere completely to the ThemeRoller theme standards. This JIRA is to clean-up any straggler issues that remain.
Per-Component Issues:
ace:accordion
X Missing bottom header border ("Smoothness")
ace:dataTable
X row selection either missing top border or shouldn't have borders at all?
X Missing rounded borders on header, but they are there on footer.
X Col Grouping doesn't use themeroller styles for group summary rows
- app controlled - no appropriate theme roller style
X incorrect selected row styling / color?
- in comparison to primefaces - pf is wrong
ace:dialog
X close X button incorrectly styled
ace:menu (s)
X missing hover/highlight borders (?)
- left as is, none of wijmo samples show borders in hover/highlight items; trying to change that causes all items in default state to have borders as well, making menus not look appealing
X missing popup shadows
- added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)
ace:autoCompleteEntry / ace:comboBox
X Incorrect hover/highlight styling
- looks fine to me
X incorrect popup list font styling (size)
- both are font-size 13px - difference is an illusion
ace:tableConfigPanel
X Not using themeroller background styling for body of panel.
ace:dateTimeEntry
X showcase Overview, header is too tall vs. popup which is correct.
- fixed by jqui css backport
ace:list
X incorrect row/element default styling, selection styling
- same styling as table, recommended classes from JQUI
ace:panel
X menu icon has incorrect padding on right/left side ("south-street")
- fixed by removing showcase specific style hacks
ace:selectMenu
X Missing list highlight rounded borders
ace:tabSet
X Incorrect label font styling
- looks fine to me
X Incorrect bottom border on selected tab (shouldn't have one)
- this is a change in JQUI 1.9 - we need to upgrade
X Missing mouse hover styling
- was removed from component as optimization? YUI / JQUI normally have hover eventing
ace:tooltip
X Incorrect tooltip border styling/shadowing
- added drop shadow rule
X Incorrect tooltip text styling
- font-size was defined by tooltip theme, now inherited
ace:tree
X Incorrect none-rounded highlight/selected styling
- item with rounded corners doesn't look good floating in a tree with no other rounded corners
- tiny items like this don't look good with rounded corners
- would need to increase padding
Per-Component Issues:
ace:accordion
X Missing bottom header border ("Smoothness")
ace:dataTable
X row selection either missing top border or shouldn't have borders at all?
X Missing rounded borders on header, but they are there on footer.
X Col Grouping doesn't use themeroller styles for group summary rows
- app controlled - no appropriate theme roller style
X incorrect selected row styling / color?
- in comparison to primefaces - pf is wrong
ace:dialog
X close X button incorrectly styled
ace:menu (s)
X missing hover/highlight borders (?)
- left as is, none of wijmo samples show borders in hover/highlight items; trying to change that causes all items in default state to have borders as well, making menus not look appealing
X missing popup shadows
- added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)
ace:autoCompleteEntry / ace:comboBox
X Incorrect hover/highlight styling
- looks fine to me
X incorrect popup list font styling (size)
- both are font-size 13px - difference is an illusion
ace:tableConfigPanel
X Not using themeroller background styling for body of panel.
ace:dateTimeEntry
X showcase Overview, header is too tall vs. popup which is correct.
- fixed by jqui css backport
ace:list
X incorrect row/element default styling, selection styling
- same styling as table, recommended classes from JQUI
ace:panel
X menu icon has incorrect padding on right/left side ("south-street")
- fixed by removing showcase specific style hacks
ace:selectMenu
X Missing list highlight rounded borders
ace:tabSet
X Incorrect label font styling
- looks fine to me
X Incorrect bottom border on selected tab (shouldn't have one)
- this is a change in JQUI 1.9 - we need to upgrade
X Missing mouse hover styling
- was removed from component as optimization? YUI / JQUI normally have hover eventing
ace:tooltip
X Incorrect tooltip border styling/shadowing
- added drop shadow rule
X Incorrect tooltip text styling
- font-size was defined by tooltip theme, now inherited
ace:tree
X Incorrect none-rounded highlight/selected styling
- item with rounded corners doesn't look good floating in a tree with no other rounded corners
- tiny items like this don't look good with rounded corners
- would need to increase padding
All style issue addressed.