ICEfaces
  1. ICEfaces
  2. ICE-9420

ACE Component ThemeRoller theme compliance issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3.x, ACE components
    • Assignee Priority:
      P1
    • Affects:
      Compatibility/Configuration

      Description

      Many of the ACE components do not adhere completely to the ThemeRoller theme standards. This JIRA is to clean-up any straggler issues that remain.

      Per-Component Issues:

      ace:accordion
      X Missing bottom header border ("Smoothness")

      ace:dataTable
      X row selection either missing top border or shouldn't have borders at all?
      X Missing rounded borders on header, but they are there on footer.
      X Col Grouping doesn't use themeroller styles for group summary rows
          - app controlled - no appropriate theme roller style
      X incorrect selected row styling / color?
          - in comparison to primefaces - pf is wrong

      ace:dialog
      X close X button incorrectly styled

      ace:menu (s)
      X missing hover/highlight borders (?)
         - left as is, none of wijmo samples show borders in hover/highlight items; trying to change that causes all items in default state to have borders as well, making menus not look appealing
      X missing popup shadows
         - added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)

      ace:autoCompleteEntry / ace:comboBox
      X Incorrect hover/highlight styling
         - looks fine to me
      X incorrect popup list font styling (size)
         - both are font-size 13px - difference is an illusion

      ace:tableConfigPanel
      X Not using themeroller background styling for body of panel.

      ace:dateTimeEntry
      X showcase Overview, header is too tall vs. popup which is correct.
          - fixed by jqui css backport

      ace:list
      X incorrect row/element default styling, selection styling
         - same styling as table, recommended classes from JQUI

      ace:panel
      X menu icon has incorrect padding on right/left side ("south-street")
         - fixed by removing showcase specific style hacks

      ace:selectMenu
      X Missing list highlight rounded borders

      ace:tabSet
      X Incorrect label font styling
         - looks fine to me
      X Incorrect bottom border on selected tab (shouldn't have one)
         - this is a change in JQUI 1.9 - we need to upgrade
      X Missing mouse hover styling
         - was removed from component as optimization? YUI / JQUI normally have hover eventing

      ace:tooltip
      X Incorrect tooltip border styling/shadowing
         - added drop shadow rule
      X Incorrect tooltip text styling
         - font-size was defined by tooltip theme, now inherited

      ace:tree
      X Incorrect none-rounded highlight/selected styling
         - item with rounded corners doesn't look good floating in a tree with no other rounded corners
         - tiny items like this don't look good with rounded corners
         - would need to increase padding

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37380 Tue Aug 13 10:01:26 MDT 2013 art.zambrano ICE-9420 added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/readme.txt
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37379 Tue Aug 13 09:58:53 MDT 2013 art.zambrano ICE-9420 added drop shadow to flyout submenus in ace:menu, ace:menuBar, ace:contextMenu (including root menu) and ace:menuButton (including root menu)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/menu/menu.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37274 Mon Jul 29 16:20:31 MDT 2013 nils.lundquist ICE-9420 - Added missing space character in SelectMenuRenderer
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37273 Mon Jul 29 16:05:09 MDT 2013 nils.lundquist ICE-9420 - Added tooltip drop shadow rule
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-2.0.0.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37272 Mon Jul 29 15:55:48 MDT 2013 nils.lundquist ICE-9420 - QTip font size no longer defined by QTip theme.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/demo_template.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-2.0.0.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37269 Mon Jul 29 15:29:47 MDT 2013 nils.lundquist ICE-9420 - Fixed ace:tabset double borders. Added hover styling.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/yui/2_8_2/tabview/tabview.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37061 Tue Jul 23 15:05:21 MDT 2013 nils.lundquist ICE-9420 - Added DataTable mandatory resource back to main-template.xhtml
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37060 Tue Jul 23 14:47:56 MDT 2013 nils.lundquist ICE-9420 - Redesigned ace:selectMenu button.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/selectmenu/selectMenuOverview.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37045 Mon Jul 22 16:27:56 MDT 2013 nils.lundquist ICE-9420 - Redesigned ace:selectMenu. Removed inline style. Removed theme specific styling. Adds JQUI classes to add borders / backgrounds to expected locations. Removed JQUI classes adding unexpected border and backgrounds.
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/theme.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37043 Mon Jul 22 15:24:06 MDT 2013 nils.lundquist ICE-9420 - Added jquery-ui.css as independantly loaded resource.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/resource-dependency.xml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/build.xml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources-meta/resource-dependency.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37038 Mon Jul 22 10:39:11 MDT 2013 nils.lundquist ICE-9420 - Improved panel styling: Improved spacing and alignment, improved button layout, added missing borders. Removed showcase specific and unessecary style hacks.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/demo_template.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/panel/panel.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase-portlet/src/main/webapp/resources/ice.samples.showcase/demo_template.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/showcase_styles.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37028 Thu Jul 18 16:29:38 MDT 2013 nils.lundquist ICE-9420 - Relayout of ace:panel header buttons.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/Panel.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/panel/panel.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/content-template.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37023 Thu Jul 18 15:25:28 MDT 2013 nils.lundquist ICE-9420 - Backported JQUI style fix from JQUI 10.1.3
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37019 Thu Jul 18 14:27:44 MDT 2013 nils.lundquist ICE-9420 - Add 'double' row style to hack overlapping highlighted row state borders.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37018 Thu Jul 18 14:26:47 MDT 2013 nils.lundquist ICE-9420 - Removed jquery-css dependencies.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapMarkerMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapInfoWindowMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapOverlayMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapAutocompleteMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapEventMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/resources/ACEResourceNames.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapLayerMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapControlMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapServicesMeta.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37006 Wed Jul 17 16:14:54 MDT 2013 nils.lundquist ICE-9420 - Removed datatable rounded corners.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableConstants.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37000 Wed Jul 17 13:42:36 MDT 2013 nils.lundquist ICE-9420 - Fixed ace:tableConfigPanel cell backgrounds
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tableconfigpanel/tableconfigpanel.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36999 Wed Jul 17 13:26:09 MDT 2013 nils.lundquist ICE-9420 - Ensure theme css dynamically merged after compile-time merged base css.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/resource-dependency.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36978 Tue Jul 16 15:56:27 MDT 2013 nils.lundquist ICE-9420 - Removed accordion border hiding and extraneous positioning rules.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.css

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: