ICEfaces
  1. ICEfaces
  2. ICE-4134

Portlet styling of Component Showcase portlets is mangled

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8RC1
          • Fix Version/s: 1.8RC2, 1.8
          • Component/s: Framework, Sample Apps
          • Labels:
            None
          • Environment:
            portals portlets
          • Affects:
            Sample App./Tutorial

            Description

            The layout and styling of the Component Showcase portlets is off in testing of Liferay. It was originally thought that is was due to theme/style changes in the latest Liferay (5.2.1) but now looks as though it's due to a recent change in ICEfaces.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Deryk Sinotte added a comment -

              It appears that the regression is due to changes made in ICE-4070. The simplifying of the code for getting resource URLs means that the outputStyle component was no longer retrieving the necessary stylesheet. This is what we had for each portlet that used to work:

              <ice:outputStyle href="./css/showcase_style.css"/>

              The D2DViewHandler.getResourceURL() method used to correct for this relative URL but no longer does. Changing the portlets to use an absolute URL appears to fix the issue:

              <ice:outputStyle href="/css/showcase_style.css"/>

              Show
              Deryk Sinotte added a comment - It appears that the regression is due to changes made in ICE-4070 . The simplifying of the code for getting resource URLs means that the outputStyle component was no longer retrieving the necessary stylesheet. This is what we had for each portlet that used to work: <ice:outputStyle href="./css/showcase_style.css"/> The D2DViewHandler.getResourceURL() method used to correct for this relative URL but no longer does. Changing the portlets to use an absolute URL appears to fix the issue: <ice:outputStyle href="/css/showcase_style.css"/>
              Hide
              Permalink
              Deryk Sinotte added a comment -

              The relevant files were all updated to use absolute references to the stylesheet.

              Show
              Deryk Sinotte added a comment - The relevant files were all updated to use absolute references to the stylesheet.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: