ICEfaces
  1. ICEfaces
  2. ICE-4134

Portlet styling of Component Showcase portlets is mangled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8RC1
    • Fix Version/s: 1.8RC2, 1.8
    • Component/s: Framework, Sample Apps
    • Labels:
      None
    • Environment:
      portals portlets
    • Affects:
      Sample App./Tutorial

      Description

      The layout and styling of the Component Showcase portlets is off in testing of Liferay. It was originally thought that is was due to theme/style changes in the latest Liferay (5.2.1) but now looks as though it's due to a recent change in ICEfaces.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18429 Wed Feb 25 13:13:10 MST 2009 deryk.sinotte ICE-4134: Correction for styling issues in portlets.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Divider.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_Resizable_Columns.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Rich_Text_Editor.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Tabset_Dynamic.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Tabset_Static.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_FileUpload.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Charts.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_SetEventPhase.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Calendar.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Stack.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_ConnectionStatus.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_DataPaging.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_Expandable.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Tooltip.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Selection.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_OutputResource.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Autocomplete.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_SortableHeader.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_ButtonsAndLinks.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Series.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_GMap.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_DragAndDrop.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Border.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Positioned.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_Grouping.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_TextEntry.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_ProgressBar.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_Columns.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Effects.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Popup.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Tree.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Menubar.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Panel_Collapsible.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Media_Player.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/web/Components_Table_RowSelection.jspx
        Deryk Sinotte created issue -
        Deryk Sinotte made changes -
        Field Original Value New Value
        Salesforce Case []
        Component/s Framework [ 10013 ]
        Component/s Sample Apps [ 10010 ]
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P1
        Assignee Deryk Sinotte [ deryk.sinotte ]
        Deryk Sinotte made changes -
        Hide
        Deryk Sinotte added a comment -

        It appears that the regression is due to changes made in ICE-4070. The simplifying of the code for getting resource URLs means that the outputStyle component was no longer retrieving the necessary stylesheet. This is what we had for each portlet that used to work:

        <ice:outputStyle href="./css/showcase_style.css"/>

        The D2DViewHandler.getResourceURL() method used to correct for this relative URL but no longer does. Changing the portlets to use an absolute URL appears to fix the issue:

        <ice:outputStyle href="/css/showcase_style.css"/>

        Show
        Deryk Sinotte added a comment - It appears that the regression is due to changes made in ICE-4070 . The simplifying of the code for getting resource URLs means that the outputStyle component was no longer retrieving the necessary stylesheet. This is what we had for each portlet that used to work: <ice:outputStyle href="./css/showcase_style.css"/> The D2DViewHandler.getResourceURL() method used to correct for this relative URL but no longer does. Changing the portlets to use an absolute URL appears to fix the issue: <ice:outputStyle href="/css/showcase_style.css"/>
        Hide
        Deryk Sinotte added a comment -

        The relevant files were all updated to use absolute references to the stylesheet.

        Show
        Deryk Sinotte added a comment - The relevant files were all updated to use absolute references to the stylesheet.
        Deryk Sinotte made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Affects [Sample App./Tutorial]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.8RC2 [ 10163 ]
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Deryk Sinotte [ deryk.sinotte ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: