ICEfaces
  1. ICEfaces
  2. ICE-4070

optimize ViewHandler.getResourceURL

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8DR#2
          • Fix Version/s: 1.8RC1, 1.8
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            D2DViewHandler.getResourceURL is called frequently and is significantly more complex in implementation than the standard JSF version

            Prior to the change (based on the optimization in ICE-4057):

            lifecycle took 9686000 RENDER: 8435000
            lifecycle took 9514000 RENDER: 8344000
            lifecycle took 9629000 RENDER: 8462000
            lifecycle took 9473000 RENDER: 8282000
            average:

            after the change:

            lifecycle took 7995000 RENDER: 6801000
            lifecycle took 7584000 RENDER: 6419000
            lifecycle took 7662000 RENDER: 6476000
            lifecycle took 7659000 RENDER: 6501000

            Comparing average times, this yields a 20% improvement.

              Activity

              Hide
              Permalink
              Ted Goddard added a comment -

              Checked in change assumes that the context path will not change during the lifetime of the ExternalContext.

              Show
              Ted Goddard added a comment - Checked in change assumes that the context path will not change during the lifetime of the ExternalContext.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: