ICEfaces
  1. ICEfaces
  2. ICE-9464

resource-dependency.xml should define resource inclusion as well as ordering

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P2

      Description

      This xml definition builds a list of resources objects used to determine the ordering of resources, but it could be made more useful if it also defined resources that are required to be included when the target dependant resource is loaded- instead of just defining head order relative to the dependant resource.

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          Modified ResourceOrdering class to also collect all the transitive dependencies for each of the resource required by the components. Introduced resource handlers for bridge and compat code that will serve up the compressed or uncompressed version of the resource based on the project stage. There's also a resource handler for themes that for the required "theme.css[icefaces.ace]" resource will serve up the content of the selected theme. Updated the dependencies files.

          Show
          Mircea Toma added a comment - Modified ResourceOrdering class to also collect all the transitive dependencies for each of the resource required by the components. Introduced resource handlers for bridge and compat code that will serve up the compressed or uncompressed version of the resource based on the project stage. There's also a resource handler for themes that for the required "theme.css [icefaces.ace] " resource will serve up the content of the selected theme. Updated the dependencies files.
          Hide
          Deryk Sinotte added a comment -

          Any apps that are deployed with MyFaces and include icefaces-ace.jar will throw the following exception:

          java.lang.NullPointerException: listener cannot be null.
          	at org.apache.myfaces.application.ApplicationImpl.checkNull(ApplicationImpl.java:1999)
          	at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:971)
          	at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:963)
          	at org.apache.myfaces.config.FacesConfigurator.configureApplication(FacesConfigurator.java:581)
          	at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:419)
          	at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:370)
          	at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:73)
          	at org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:143)
          	at org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:119)
          	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4887)
          	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5381)
          	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
          	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
          	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
          	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)
          	at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:976)
          	at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1653)
          	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
          	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
          	at java.lang.Thread.run(Thread.java:680)
          
          

          It seems that the problem is related to a change in:

          icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml

          In there we commented out only part of a listener and MyFaces doesn't seem to like that:

                  <system-event-listener>
                      <!--<system-event-listener-class>org.icefaces.ace.component.themeselect.ThemeSelectRenderer$AddTheme</system-event-listener-class>-->
                      <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
                  </system-event-listener>
          
          Show
          Deryk Sinotte added a comment - Any apps that are deployed with MyFaces and include icefaces-ace.jar will throw the following exception: java.lang.NullPointerException: listener cannot be null. at org.apache.myfaces.application.ApplicationImpl.checkNull(ApplicationImpl.java:1999) at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:971) at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:963) at org.apache.myfaces.config.FacesConfigurator.configureApplication(FacesConfigurator.java:581) at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:419) at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:370) at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:73) at org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:143) at org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:119) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4887) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5381) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633) at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:976) at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1653) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) It seems that the problem is related to a change in: icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml In there we commented out only part of a listener and MyFaces doesn't seem to like that: <system-event-listener> <!--<system-event-listener-class>org.icefaces.ace.component.themeselect.ThemeSelectRenderer$AddTheme</system-event-listener-class>--> <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class> </system-event-listener>
          Hide
          Mircea Toma added a comment -

          Removed completely unused listener ThemeSelectRenderer$AddTheme.

          Show
          Mircea Toma added a comment - Removed completely unused listener ThemeSelectRenderer$AddTheme.
          Hide
          Mircea Toma added a comment -

          Backported fix for 'compat' to have the specific resources served uncompressed when project stage is 'Development'.

          Show
          Mircea Toma added a comment - Backported fix for 'compat' to have the specific resources served uncompressed when project stage is 'Development'.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Nils Lundquist
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: