[ICE-9464] resource-dependency.xml should define resource inclusion as well as ordering - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.0.BETA, 4.0
Component/s: ACE-Components
Labels:
None
Environment:
*

Assignee Priority:
P2

Description

This xml definition builds a list of resources objects used to determine the ordering of resources, but it could be made more useful if it also defined resources that are required to be included when the target dependant resource is loaded- instead of just defining head order relative to the dependant resource.

Issue Links

blocks

ICE-9465 Resource dependency annotations should only define leaf dependencies

Closed

ICE-9502 Provide load only dependency configuration for resources

Closed

Activity

Ascending order - Click to sort in descending order

Nils Lundquist created issue - 23/Jul/13 3:18 PM

Nils Lundquist made changes - 23/Jul/13 3:18 PM

Field	Original Value	New Value
Assignee		Mircea Toma [ mircea.toma ]

Nils Lundquist made changes - 23/Jul/13 3:23 PM

Link

This issue blocks ~~ICE-9465~~ [ ~~ICE-9465~~ ]

Ken Fyten made changes - 24/Jul/13 3:47 PM

Assignee Priority

P2 [ 10011 ]

Hide

Permalink

Mircea Toma added a comment - 02/Aug/13 1:48 PM

Modified ResourceOrdering class to also collect all the transitive dependencies for each of the resource required by the components. Introduced resource handlers for bridge and compat code that will serve up the compressed or uncompressed version of the resource based on the project stage. There's also a resource handler for themes that for the required "theme.css[icefaces.ace]" resource will serve up the content of the selected theme. Updated the dependencies files.

Show

Mircea Toma added a comment - 02/Aug/13 1:48 PM Modified ResourceOrdering class to also collect all the transitive dependencies for each of the resource required by the components. Introduced resource handlers for bridge and compat code that will serve up the compressed or uncompressed version of the resource based on the project stage. There's also a resource handler for themes that for the required "theme.css [icefaces.ace] " resource will serve up the content of the selected theme. Updated the dependencies files.

Mircea Toma made changes - 02/Aug/13 1:48 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#37299	Fri Aug 02 13:51:21 MDT 2013	mircea.toma	~~ICE-9464~~ Modified ResourceOrdering class to also collect all the transitive dependencies for each of the resource required by the components. Introduced resource handlers for bridge and compat code that will serve up the compressed or uncompressed version of the resource based on the project stage. There's also a resource handler for themes that for the required "theme.css[icefaces.ace]" resource will serve up the content of the selected theme. Updated the dependencies files.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java ADD /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSymbolicResourceHandler.java ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSymbolicResourceHandler.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/resources/META-INF/resource-dependency.xml MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/resource-dependency.xml MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resource-dependency.xml MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/ResourceOrdering.java ADD /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSymbolicResourceHandler.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/resources/META-INF/faces-config.xml MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/CoalescingResourceHandler.java MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources-meta/resource-dependency.xml

Mircea Toma made changes - 05/Aug/13 10:16 AM

Link

This issue blocks ~~ICE-9502~~ [ ~~ICE-9502~~ ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#37302	Mon Aug 05 11:41:01 MDT 2013	mircea.toma	~~ICE-9464~~ Fix dependency names.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/ResourceOrdering.java

Hide

Permalink

Deryk Sinotte added a comment - 07/Aug/13 9:18 AM

Any apps that are deployed with MyFaces and include icefaces-ace.jar will throw the following exception:

java.lang.NullPointerException: listener cannot be null.
	at org.apache.myfaces.application.ApplicationImpl.checkNull(ApplicationImpl.java:1999)
	at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:971)
	at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:963)
	at org.apache.myfaces.config.FacesConfigurator.configureApplication(FacesConfigurator.java:581)
	at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:419)
	at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:370)
	at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:73)
	at org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:143)
	at org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:119)
	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4887)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5381)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)
	at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:976)
	at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1653)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:680)

It seems that the problem is related to a change in:

icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml

In there we commented out only part of a listener and MyFaces doesn't seem to like that:

        <system-event-listener>
            <!--<system-event-listener-class>org.icefaces.ace.component.themeselect.ThemeSelectRenderer$AddTheme</system-event-listener-class>-->
            <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
        </system-event-listener>

Show

Deryk Sinotte added a comment - 07/Aug/13 9:18 AM Any apps that are deployed with MyFaces and include icefaces-ace.jar will throw the following exception: java.lang.NullPointerException: listener cannot be null. at org.apache.myfaces.application.ApplicationImpl.checkNull(ApplicationImpl.java:1999) at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:971) at org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(ApplicationImpl.java:963) at org.apache.myfaces.config.FacesConfigurator.configureApplication(FacesConfigurator.java:581) at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:419) at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:370) at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:73) at org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:143) at org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:119) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4887) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5381) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633) at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:976) at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1653) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) It seems that the problem is related to a change in: icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml In there we commented out only part of a listener and MyFaces doesn't seem to like that: <system-event-listener>  <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class> </system-event-listener>

Deryk Sinotte made changes - 07/Aug/13 9:18 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 08/Aug/13 9:57 AM

Removed completely unused listener ThemeSelectRenderer$AddTheme.

Show

Mircea Toma added a comment - 08/Aug/13 9:57 AM Removed completely unused listener ThemeSelectRenderer$AddTheme.

Mircea Toma made changes - 08/Aug/13 9:57 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#37334	Thu Aug 08 10:00:17 MDT 2013	mircea.toma	~~ICE-9464~~ Remove completely unused listener ThemeSelectRenderer$AddTheme.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/faces-config.xml

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#38597	Mon Oct 14 10:37:03 MDT 2013	mircea.toma	~~ICE-9464~~ Added symbolic resource handler that serves up the compressed or uncompressed version of the compat resources based on the project stage.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/component-metadata/src/main/resources/com/icesoft/jsfmeta/templates/jsf11/resources/faces-config-rt.ftl

Ken Fyten made changes - 21/Nov/13 10:57 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 02/Dec/13 10:48 AM

Backported fix for 'compat' to have the specific resources served uncompressed when project stage is 'Development'.

Show

Mircea Toma added a comment - 02/Dec/13 10:48 AM Backported fix for 'compat' to have the specific resources served uncompressed when project stage is 'Development'.

Mircea Toma made changes - 02/Dec/13 10:48 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 14/Nov/14 5:03 PM

Fix Version/s

4.0 [ 11382 ]

Ken Fyten made changes - 14/Nov/14 5:19 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Nils Lundquist

Votes:

0 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

23/Jul/13 3:18 PM

Updated:

14/Nov/14 5:19 PM

Resolved:

02/Dec/13 10:48 AM