ICEfaces
  1. ICEfaces
  2. ICE-7465

ace:dialog - Modal overlay is not removed when closing dialog in IE

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.1-Beta2
          • Fix Version/s: 3.0.RC1, 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            IE7, IE8, ICEfaces 2.1.0 Beta2
          • Assignee Priority:
            P1

            Description

            When closing a modal dialog using the visible attribute the modal overlay does not get removed in IE browsers. This is working fine in Firefox

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case10574Example.war [ 13761 ]
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows issue. Dialog can be opened via two buttons, one calls and action method the other an actionListener. Upon opening the dialog, there are two similar buttons that will do the same. Using the action or the actionListener will reproduce the issue upon closing the dialog.

              Show
              Arran Mccullough added a comment - Attached test case that shows issue. Dialog can be opened via two buttons, one calls and action method the other an actionListener. Upon opening the dialog, there are two similar buttons that will do the same. Using the action or the actionListener will reproduce the issue upon closing the dialog.
              Arran Mccullough made changes -
              Attachment Case10574Example.zip [ 13762 ]
              Arran Mccullough made changes -
              Salesforce Case [5007000000JLEte]
              Arran Mccullough made changes -
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Assignee Priority P1
              Assignee Ken Fyten [ ken.fyten ] yip.ng [ yip.ng ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              In fix for ICE-7361, jQuery event mechanism was used to trigger click event of title bar close button (and thus custom dialog close event) to close previous instance of dialog. Seems this jQuery event mechanism doesn't work in IE in this case. Need to trace and compare the jQuery code paths to see what's being executed differently in IE.

              Show
              yip.ng added a comment - - edited In fix for ICE-7361 , jQuery event mechanism was used to trigger click event of title bar close button (and thus custom dialog close event) to close previous instance of dialog. Seems this jQuery event mechanism doesn't work in IE in this case. Need to trace and compare the jQuery code paths to see what's being executed differently in IE.
              Hide
              Permalink
              yip.ng added a comment -

              Fixed. Figured out another API that works for IE as well in this case, without needing to change jquery.js or jquery-ui.js.

              Revision: 26408

              Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js

              Show
              yip.ng added a comment - Fixed. Figured out another API that works for IE as well in this case, without needing to change jquery.js or jquery-ui.js. Revision: 26408 Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 3.0.RC1 [ 10300 ]
              Ken Fyten made changes -
              Fix Version/s 3.0 [ 10241 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: