Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.1-Beta
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ICEfaces 2.1.0 Beta 10142011
-
Assignee Priority:P1
-
Affects:Compatibility/Configuration
-
Workaround Exists:Yes
-
Workaround Description:Remove f:ajax tag
Description
<f:ajax execute="@form" render="@form"/>
An additional modal dialog overlay is displayed. When the dialog is closed this overlay remains. This issue seems to only occur if using the visible attribute to open the popup.
If using the widgetVar property to open/close the dialog, clicking on the button with the f:ajax tag causes the popup to be closed.
Attached test case demonstrates both issues.
-
Hide
-
-
META-INF/MANIFEST.MF
-
META-INF/context.xml
-
WEB-INF/classes/.../example/TestBean.class
-
WEB-INF/lib/commons-beanutils.jar
-
WEB-INF/lib/commons-collections.jar
-
WEB-INF/lib/commons-digester.jar
-
WEB-INF/lib/commons-logging.jar
-
WEB-INF/lib/icefaces-ace.jar
-
WEB-INF/lib/icefaces-compat.jar
-
WEB-INF/lib/icefaces.jar
-
WEB-INF/lib/javax.faces.jar
-
WEB-INF/web.xml
-
welcomeICEfaces.xhtml
-
-
-
Hide
-
-
Case10624Example/build.xml
-
Case10624Example/.../ant-deploy.xml
-
Case10624Example/.../build-impl.xml
-
Case10624Example/.../genfiles.properties
-
Case10624Example/.../private.properties
-
Case10624Example/.../project.properties
-
Case10624Example/nbproject/project.xml
-
Case10624Example/src/conf/MANIFEST.MF
-
Case10624Example/src/.../TestBean.java
-
Case10624Example/web/.../context.xml
-
Case10624Example/web/WEB-INF/web.xml
-
Case10624Example/.../welcomeICEfaces.xhtml
-
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
See screenshot-01.png for changes required for problem 3. Note that no visible attribute is the same as hard coding visible to false. There is no third state. So the minute you open the dialog using testDlg.show() the dialog is already out of sync with the server.
Same problem as <ace:panel> expand/collapse state problem I described in email some time ago. For an even simpler demonstration of the problem, see screenshot-02.png of the notification panel demo.
Fixed. Note that these are general problems applicable to all components. They just show up more glaringly in dialog because of the unfortunate coupling of visible and autoOpen, and the added complexity of the overlay. If we continue to want the components to be more sever-side-oriented like in 1.8, there will be a lot more of these fixes to do.
Revision: 26185
Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
Command: Commit
Modified: C:\svn\ossrepo\icefaces-ee\tags\icefaces-2.1.0.BETA2\icefaces\ace\component\resources\icefaces.ace\dialog\dialog.js
Modified: C:\svn\ossrepo\icefaces-ee\tags\icefaces-2.1.0.BETA2\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogRenderer.java
Completed: At revision: 26189
Problems caused by:
1. Coupling of visible attribute to dialog autoOpen option. autoOpen is a once-only thing, not meant to be a toggle. Long term solution is to decouple visible and autoOpen.
2. render="@form" creates another dialog instance. How do you find the first instance and close it without getting into an infinite close event loop? Not trivial. There is much more going on in a close than just hiding the dialog and overlay. Also, you want to simulate a close event, not sneakily disturb the component states and HTML and CSS behind the component's back.
3. User's lack of knowledge or misunderstanding on client-side actions/states. Any state changes caused by client-side actions must be synced with the server if you want to also control the state from the server side.