ICEfaces
  1. ICEfaces
  2. ICE-7465

ace:dialog - Modal overlay is not removed when closing dialog in IE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-Beta2
    • Fix Version/s: 3.0.RC1, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IE7, IE8, ICEfaces 2.1.0 Beta2
    • Assignee Priority:
      P1

      Description

      When closing a modal dialog using the visible attribute the modal overlay does not get removed in IE browsers. This is working fine in Firefox

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case that shows issue. Dialog can be opened via two buttons, one calls and action method the other an actionListener. Upon opening the dialog, there are two similar buttons that will do the same. Using the action or the actionListener will reproduce the issue upon closing the dialog.

        Show
        Arran Mccullough added a comment - Attached test case that shows issue. Dialog can be opened via two buttons, one calls and action method the other an actionListener. Upon opening the dialog, there are two similar buttons that will do the same. Using the action or the actionListener will reproduce the issue upon closing the dialog.
        Hide
        yip.ng added a comment - - edited

        In fix for ICE-7361, jQuery event mechanism was used to trigger click event of title bar close button (and thus custom dialog close event) to close previous instance of dialog. Seems this jQuery event mechanism doesn't work in IE in this case. Need to trace and compare the jQuery code paths to see what's being executed differently in IE.

        Show
        yip.ng added a comment - - edited In fix for ICE-7361 , jQuery event mechanism was used to trigger click event of title bar close button (and thus custom dialog close event) to close previous instance of dialog. Seems this jQuery event mechanism doesn't work in IE in this case. Need to trace and compare the jQuery code paths to see what's being executed differently in IE.
        Hide
        yip.ng added a comment -

        Fixed. Figured out another API that works for IE as well in this case, without needing to change jquery.js or jquery-ui.js.

        Revision: 26408


        Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js

        Show
        yip.ng added a comment - Fixed. Figured out another API that works for IE as well in this case, without needing to change jquery.js or jquery-ui.js. Revision: 26408 Modified : /icefaces-ee/scratchpads/grimlock/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js

          People

          • Assignee:
            yip.ng
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: