ICEfaces
  1. ICEfaces
  2. ICE-5975

The "Bid declined." message does not display when invalid bid is submitted using the accept bid button

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA_P01, 2.0-Beta1
    • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces 1 ICEfaces
    • Assignee Priority:
      P1
    • Affects:
      Sample App./Tutorial

      Description

      In both the 1.8 version and ICEfaces 2 versions of the Auction Monitor, the "Bid declined." message only appears if you submit an invalid bid using the Enter key. If you submit an invalid bid using the accept bid button (ie the green checkmark), the bid will be rejected but the message will not appear.

        Activity

        Hide
        Ken Fyten added a comment -

        One last thing, the app. states that any individual bid cannot be more than $1,000,000 more than the current price, but the validator is not enforcing this now.

        I'd suggest that we reduce that limit to $10,000 and enforce it. The intent is to reduce the immediate expansion of the amount fields such that they no longer render nicely in the space provided, etc.

        Show
        Ken Fyten added a comment - One last thing, the app. states that any individual bid cannot be more than $1,000,000 more than the current price, but the validator is not enforcing this now. I'd suggest that we reduce that limit to $10,000 and enforce it. The intent is to reduce the immediate expansion of the amount fields such that they no longer render nicely in the space provided, etc.
        Hide
        Carlo Guglielmin added a comment -

        r23134 - I updated the BidValidator so the max bid increase is $10,000. Also I changed the message on the page to reflect this. Only the 1.8.x compat version of auctionMonitor needed this change, as it was existing in the current 2.0 version already.

        Show
        Carlo Guglielmin added a comment - r23134 - I updated the BidValidator so the max bid increase is $10,000. Also I changed the message on the page to reflect this. Only the 1.8.x compat version of auctionMonitor needed this change, as it was existing in the current 2.0 version already.
        Hide
        Ken Fyten added a comment -

        Carlo, the commit for the max $10K bid limit was made to icefaces2/trunk, not icefaces/trunk. Please review and correct.

        Show
        Ken Fyten added a comment - Carlo, the commit for the max $10K bid limit was made to icefaces2/trunk, not icefaces/trunk. Please review and correct.
        Hide
        Carlo Guglielmin added a comment -

        r23147 - Ported max bid change to icefaces/trunk.

        Show
        Carlo Guglielmin added a comment - r23147 - Ported max bid change to icefaces/trunk.
        Hide
        Mandeep Hayher added a comment -

        Tested successfully on:
        Icefaces1.8 trunk revision# 23161
        Server: Tomcat6
        Browsers: FF3.6, IE8 & Opera10.60

        Show
        Mandeep Hayher added a comment - Tested successfully on: Icefaces1.8 trunk revision# 23161 Server: Tomcat6 Browsers: FF3.6, IE8 & Opera10.60

          People

          • Assignee:
            Carlo Guglielmin
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: