This issue was originally flagged as a regression in ICE-5915.

This is a perfect example of why we don't tell users to do work on setters and getters.

The inputText for a bid is value bound to the instance variable tempLocalBid in the AuctionMonitorItemBean. The setter for the tempLocalBid checks to see if the bid is valid. If valid the setter assigns the new value and then calls the action Method setLocalBid. If not valid no value assignment is made and a boolean flag to show the bid error message is set to true. From a JSF point of view a lot of rules are broken with this approach but the application works as expected and the error message will show up if the bid is invalid and the original value is kept.

When the bid action event is processed with an invalid bid we don't see the error message because of the work done on the setter. When the bid button is pressed a new JSF lifecycle is kicked off. Because we don't use an JSF validator the Bean setters all get called at which point the above logic kicks in effectively wiping the bad value. Next our action event is processed but the model has the old original value because of the setter interfered with the data. The action logic sees that there is nothing wrong with the bid and sets the boolean flag to hide the message.

The proper way to handle this logic is to avoid doing any work on the setter. Instead opting for a bidValitor that if fails prevents the action from being executed. And avoids the doubling up of logic like we are currently seeing.

Updated the input field to use a custom bid validator to validate bid values. For the most part standard validation is used but we still store the error message in a bean to avoid the message from getting cleared on a server push.

Please apply these fixes to the icefaces/trunk/samples/auction-monitor version also.

Oops. Testing shows that a "Bid declined, too small" message appears even when you enter a valid bid.
Also, there doesn't seem to be any max. bid, when the app. says you can't bid more than 1,000,000 more than the last bid.

Also, suggest using "too low/high" instead of "small.big" in error messages.

So the BidValidator added by Pat seems to have fixed this issue. In my testing the "Bid declined, too small" message appears properly if the bid is less than the current bid, otherwise no message appears (as expected). So that looks like it's working.

I did notice that the original icefaces/trunk/ didn't receive these changes, so I'll port those across.

This seems to be working fine now on icefaces/trunk. Can you change it so the default next bid value is always $1 higher than the current bid?

Also noticing this warning in the tomcat log after testing IF2 compat auctionMonitor. There is one entry for each invalid response, although the messages did show up on the browser correctly:

Nov 10, 2010 12:25:25 PM com.sun.faces.renderkit.RenderKitUtils renderUnhandledMessages
INFO: WARNING: FacesMessage(s) have been enqueued, but may not have been displayed.
sourceId=iceForm:iceTable:1:item_localBid[severity=(ERROR 2), summary=(null), detail=(<br />Bid declined, too low.)]

I've added functionality so the "new bid" field defaults to $1 higher than the current max bid, for both the 1.8.x version and the 2.0 compat version.

Marking as fixed as validation works and a few improvements listed under this bug have been checked in.

One last thing, the app. states that any individual bid cannot be more than $1,000,000 more than the current price, but the validator is not enforcing this now.

I'd suggest that we reduce that limit to $10,000 and enforce it. The intent is to reduce the immediate expansion of the amount fields such that they no longer render nicely in the space provided, etc.

r23134 - I updated the BidValidator so the max bid increase is $10,000. Also I changed the message on the page to reflect this. Only the 1.8.x compat version of auctionMonitor needed this change, as it was existing in the current 2.0 version already.

Carlo, the commit for the max $10K bid limit was made to icefaces2/trunk, not icefaces/trunk. Please review and correct.

r23147 - Ported max bid change to icefaces/trunk.

Tested successfully on:
Icefaces1.8 trunk revision# 23161
Server: Tomcat6
Browsers: FF3.6, IE8 & Opera10.60