ICEfaces-EE-1.8.2-GA

Path: icefaces
URL: http://server.ice:8888/svn/ossrepo/icefaces-ee/branches/icefaces-ee-1.8.2/icefaces
Repository Root: http://server.ice:8888/svn/ossrepo
Repository UUID: 8668f098-c06c-11db-ba21-f49e70c34f74
Revision: 19839
Node Kind: directory
Last Changed Author: jack.van.ooststroom
Last Changed Rev: 19836
Last Changed Date: 2009-12-01 07:49:13 -0700 (Tue, 01 Dec 2009)

Seems not all files were synced up to the ICEfaces EE 1.8.2.GA. menu.js has changes way back (traced up to rev. 19116 so far) that haven't been ported. They are extensive changes as well. Can't try create-patch-apply-patch either, because in compat JS files are merged into one big file. Even if we could figure out a way to do apply patch there could be many conflicts that still require hand editing.

Revision: 22019

Modified : /icefaces2/trunk/icefaces/compat/component-metadata/build.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/java/com/icesoft/metadata/generators/TLDGenerator.java
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/custom/jseventlistener-component.xml
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/custom/jseventlistener-renderer.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/extended-faces-config.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/faces-config-base.xml
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice/components/JSEventListener-component.xml
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice/renderers/JSEventListener-renderer.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-datapaginator-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-inputFile-props.xml
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-jseventlistener-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-menunode-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml
Added : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-att-partialSubmitDelay-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-form-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-selectManyListbox-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-selectManyMenu-props.xml
Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-selectOneListbox-props.xml
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/CSS_DEFAULT.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/datapaginator/DataPaginator.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlSelectManyListbox.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlSelectManyMenu.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlSelectOneListbox.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/RowSelector.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/ListboxRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/MenuRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
Added : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/jseventlistener
Added : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/jseventlistener/JSEventListener.java
Added : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/jseventlistener/JSEventListenerRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItem.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputresource/OutputResource.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltooltip/PanelTooltip.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/model/entity/Person.java
Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/rowSelector/RowSelectController.java
Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/dataTable-rowSelection.xhtml

Lots of compile errors after merge. Fixed.

Files not done because of too complicated changes and/or too many conflicts:

/icefaces/trunk/icefaces/bridge/src/focus.js (Mircea)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlForm.java (Adnan)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java (Mark)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/loadbundle/LoadBundle.java (Adnan)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java (Adnan, Mark)

inputFile is not used in icefaces2 compat, so ignore those merge conflicts.

On 29/07/10 2:13 PM, Mandeep Arora wrote:
> Following jiras have been created to covers all new failures reported
> yesterday and today.
>
> (ICE-5944) Regression Icefaces2 - Popup Calendar not working correctly
> (ICE-5945) Regression Icefaces2 - MenuBar & Menupop submenus are not
> displayed
> (ICE-5946) Regression Icefaces2 - ICE-1545 toggle button not working
> (ICE-5947) Regression Icefaces2 - ICE-4288 Click Action & Click
> Listener are not fired on IE browser
> (ICE-5948) Regression Icefaces2 - ICE-3290 has styling problem
> (ICE-5949) Regression Icefaes2 - ICE-2193 Cannot open collapsible
> panel on IE browser
> (ICE-5950) Regression Icefaces2 - ICE-1505 cannot navigate months on
> IE browser also days are not displayed in correct sequence
> (ICE-5951) Regression Icefaces2 - ICE-2283 is failing

Note that the core API changes have been spun off into a separate JIRA for core team to review for possible inclusion into the Compat core APIs (see ICE-5986).

The remaining components that were not completed in the first pass due to complexity and/or too many conflicts need to be tackled still. Of these, only the following appear relevant to Compat Comps specifically:

/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlForm.java (Adnan)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/loadbundle/LoadBundle.java (Adnan)
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java (Adnan, Mark)

Note that care must be taken to not remove any specific changes to the IF 2.0 Compat version of these components that were made for IF 2.0 alone, while still ensuring that the Compat version includes the same intended behavior and features/bug fixes as the current 1.8 icefaces/trunk versions.

Adnan, please review the changes applied to the comps noted above on the icefaces/trunk since EE 1.8.2.GA shipped, vs. what is in the current icefaces2/compat versions to identify which new features or fixes need to be ported to the compat version to bring them insync with each other.

Assign back to Yip.

ICEfaces revision = 22381
ICEfaces 2 revision = 22381

HtmlForm: No difference anymore, probably because file copied over again at revision 21985. Still, went through all the changes since ICEfaces-EE-1.8.2-GA to make sure that they are applicable.

LoadBundle: Same as above, plus additional changes in ICEfaces 2 by Ted for ICE-5868 (Serialization-aware LoadBundle) left untouched.

UISeries: Quite a few changes missing. All studied and applied. In addition: D2DViewHandler.findComponent() replaced with CoreComponentUtils.findComponent(). Method getDataModel() changed from private to protected to get rid of warning. Fix for bug in visitTree() in ICEfaces 2 left untouched.

Revision: 22383

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelseries/UISeries.java