Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: 2.0-Beta2
-
Component/s: None
-
Labels:None
-
Environment:Server: Tomcat6
Browser: FF3.6, IE8 & Opera10.10
-
Assignee Priority:P2
Description
This test case may have been failing for long because the the scripts were incorrect. Basically the problem is the same as described originally in
If I have something like this on my page:
<ice:dataTable columnWidths="100px,200px,300px">
<ice:column rendered="true"/>
<ice:column rendered="false"/>
<ice:column rendered="true"/>
</ice:dataTable>
Then I should get this rendered in my DOM:
<table>
<tr>
<td width="100px"/>
<td width="300px"/>
</tr>
</table>
But instead, I get this:
<table>
<tr>
<td width="100px"/>
<td width="200px"/>
</tr>
</table>
Test-case available at "C:\repo\qa\trunk\Regression-Icefaces2\Nightly\
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Failing on Icefaces2 trunk revision# 22353
Was passing on Icefaces2 trunk revision# 22344
ICE-3190 is not working as expected.
The Checkbox is not cleared after clicking on the clean button, all other components on the page are cleared.
Test application is available at " \repo\qa\trunk\Regression-Icefaces2\Nightly\ICE-3190".
ICE-2283 test application has the delta submit turned by default. This caused the apparent regression. Changed web.xml to disable delta submit.
ICE-3190 is not passing yet, and does not have deltaSubmit=true specified. (See Mandeep's comment above).
Previously the decode() method assumed that the checkbox is selected only when the corresponding parameter had a value of 'on', 'true' or 'yes'. Since the encoding didn't control the 'value' attribute of the input element the renderer was relying only on the default behavior of the browser to set the value to 'on'. Unfortunately not all the browsers have the same default behavior, notably Safari which will default the value to empty string after an update.
The fix changes decode() method to reliably detect when checkbox is selected by simply verifying if the corresponding parameter name is present among the request parameters. This is enough to indicate that the checkbox is selected, the value of the corresponding parameter is not significant.
ICE-3190 passed during nightly regression test on Icefaces2 trunk revision# 22397
Assigning to Mark as it looks like something specifically component related. As Mandeep notes, this may not strictly be a regression as the test scripts have been out of sorts. Provided it's a straightforward solution, we should just fix it. If required, we can verify against 1.8 and older 2.0 releases to see how recent it might be.