ICEfaces
  1. ICEfaces
  2. ICE-5665

Re-sync compat components with latest ICEfaces trunk (1.8) changes

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha2
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 2.0 compat components.
    • Affects:
      Compatibility/Configuration

      Description

      The ICEfaces 2.0 "compat" components have fallen behind the changes in the ICEfaces trunk since ICEfaces 2.0 alpha 1 was released.

      The ICEfaces 2.0 Alpha 1 Compat components were synced up to the ICEfaces EE 1.8.2.GA components at that time via ICE-4481.

      We now need to re-sync these components with any changes made on icefaces/trunk between ICEfaces EE 1.8.2.GA and ICEfaces trunk.

        Issue Links

          Activity

          Hide
          yip.ng added a comment -

          On 29/07/10 2:13 PM, Mandeep Arora wrote:
          > Following jiras have been created to covers all new failures reported
          > yesterday and today.
          >
          > (ICE-5944) Regression Icefaces2 - Popup Calendar not working correctly
          > (ICE-5945) Regression Icefaces2 - MenuBar & Menupop submenus are not
          > displayed
          > (ICE-5946) Regression Icefaces2 - ICE-1545 toggle button not working
          > (ICE-5947) Regression Icefaces2 - ICE-4288 Click Action & Click
          > Listener are not fired on IE browser
          > (ICE-5948) Regression Icefaces2 - ICE-3290 has styling problem
          > (ICE-5949) Regression Icefaes2 - ICE-2193 Cannot open collapsible
          > panel on IE browser
          > (ICE-5950) Regression Icefaces2 - ICE-1505 cannot navigate months on
          > IE browser also days are not displayed in correct sequence
          > (ICE-5951) Regression Icefaces2 - ICE-2283 is failing

          Show
          yip.ng added a comment - On 29/07/10 2:13 PM, Mandeep Arora wrote: > Following jiras have been created to covers all new failures reported > yesterday and today. > > ( ICE-5944 ) Regression Icefaces2 - Popup Calendar not working correctly > ( ICE-5945 ) Regression Icefaces2 - MenuBar & Menupop submenus are not > displayed > ( ICE-5946 ) Regression Icefaces2 - ICE-1545 toggle button not working > ( ICE-5947 ) Regression Icefaces2 - ICE-4288 Click Action & Click > Listener are not fired on IE browser > ( ICE-5948 ) Regression Icefaces2 - ICE-3290 has styling problem > ( ICE-5949 ) Regression Icefaes2 - ICE-2193 Cannot open collapsible > panel on IE browser > (ICE-5950) Regression Icefaces2 - ICE-1505 cannot navigate months on > IE browser also days are not displayed in correct sequence > ( ICE-5951 ) Regression Icefaces2 - ICE-2283 is failing
          Hide
          Ken Fyten added a comment -

          Note that the core API changes have been spun off into a separate JIRA for core team to review for possible inclusion into the Compat core APIs (see ICE-5986).

          The remaining components that were not completed in the first pass due to complexity and/or too many conflicts need to be tackled still. Of these, only the following appear relevant to Compat Comps specifically:

          /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlForm.java (Adnan)
          /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/loadbundle/LoadBundle.java (Adnan)
          /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java (Adnan, Mark)

          Note that care must be taken to not remove any specific changes to the IF 2.0 Compat version of these components that were made for IF 2.0 alone, while still ensuring that the Compat version includes the same intended behavior and features/bug fixes as the current 1.8 icefaces/trunk versions.

          Show
          Ken Fyten added a comment - Note that the core API changes have been spun off into a separate JIRA for core team to review for possible inclusion into the Compat core APIs (see ICE-5986). The remaining components that were not completed in the first pass due to complexity and/or too many conflicts need to be tackled still. Of these, only the following appear relevant to Compat Comps specifically: /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlForm.java (Adnan) /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/loadbundle/LoadBundle.java (Adnan) /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java (Adnan, Mark) Note that care must be taken to not remove any specific changes to the IF 2.0 Compat version of these components that were made for IF 2.0 alone, while still ensuring that the Compat version includes the same intended behavior and features/bug fixes as the current 1.8 icefaces/trunk versions.
          Hide
          Ken Fyten added a comment -

          Adnan, please review the changes applied to the comps noted above on the icefaces/trunk since EE 1.8.2.GA shipped, vs. what is in the current icefaces2/compat versions to identify which new features or fixes need to be ported to the compat version to bring them insync with each other.

          Show
          Ken Fyten added a comment - Adnan, please review the changes applied to the comps noted above on the icefaces/trunk since EE 1.8.2.GA shipped, vs. what is in the current icefaces2/compat versions to identify which new features or fixes need to be ported to the compat version to bring them insync with each other.
          Hide
          Ken Fyten added a comment -

          Assign back to Yip.

          Show
          Ken Fyten added a comment - Assign back to Yip.
          Hide
          yip.ng added a comment - - edited

          ICEfaces revision = 22381
          ICEfaces 2 revision = 22381

          HtmlForm: No difference anymore, probably because file copied over again at revision 21985. Still, went through all the changes since ICEfaces-EE-1.8.2-GA to make sure that they are applicable.

          LoadBundle: Same as above, plus additional changes in ICEfaces 2 by Ted for ICE-5868 (Serialization-aware LoadBundle) left untouched.

          UISeries: Quite a few changes missing. All studied and applied. In addition: D2DViewHandler.findComponent() replaced with CoreComponentUtils.findComponent(). Method getDataModel() changed from private to protected to get rid of warning. Fix for bug in visitTree() in ICEfaces 2 left untouched.

          Revision: 22383


          Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelseries/UISeries.java

          Show
          yip.ng added a comment - - edited ICEfaces revision = 22381 ICEfaces 2 revision = 22381 HtmlForm: No difference anymore, probably because file copied over again at revision 21985. Still, went through all the changes since ICEfaces-EE-1.8.2-GA to make sure that they are applicable. LoadBundle: Same as above, plus additional changes in ICEfaces 2 by Ted for ICE-5868 (Serialization-aware LoadBundle) left untouched. UISeries: Quite a few changes missing. All studied and applied. In addition: D2DViewHandler.findComponent() replaced with CoreComponentUtils.findComponent(). Method getDataModel() changed from private to protected to get rid of warning. Fix for bug in visitTree() in ICEfaces 2 left untouched. Revision: 22383 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelseries/UISeries.java

            People

            • Assignee:
              yip.ng
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: