ICEfaces
  1. ICEfaces
  2. ICE-4695

Draggable panelGroups render excessive hidden input fields

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Within the outputted div of every draggable or droppable ice:panelGroup are rendered two hidden input fields, for communicating back to the server:

            <input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpstatus" id="iceform:_idiceform:PnlSrs:0:PnlGrpstatus"/>

            <input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpdropID" id="iceform:_idiceform:PnlSrs:0:PnlGrpdropID"/>

            That would really decrease performance, if there was a large table of draggable or droppable objects, because of the many hidden input fields. Instead, I think we should just have 3 or four fields in the form:

                dragId, dropId, status (maybe dragStatus and dropStatus, if the two statuses can have different values for the same operation)

              Activity

              Hide
              Permalink
              Adnan Durrani added a comment -

              Changes made so instead of rendering 2 hidden fields for each DND panelGroup, now the component renderes only one hidden field to a "form" regardless of number of DND panelGroups inside.

              Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
              Completed: At revision: 19084

              Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java
              Completed: At revision: 19085

              Show
              Adnan Durrani added a comment - Changes made so instead of rendering 2 hidden fields for each DND panelGroup, now the component renderes only one hidden field to a "form" regardless of number of DND panelGroups inside. Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Completed: At revision: 19084 Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java Completed: At revision: 19085

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Mark Collette
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: