ICEfaces
  1. ICEfaces
  2. ICE-4695

Draggable panelGroups render excessive hidden input fields

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Within the outputted div of every draggable or droppable ice:panelGroup are rendered two hidden input fields, for communicating back to the server:

            <input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpstatus" id="iceform:_idiceform:PnlSrs:0:PnlGrpstatus"/>

            <input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpdropID" id="iceform:_idiceform:PnlSrs:0:PnlGrpdropID"/>

            That would really decrease performance, if there was a large table of draggable or droppable objects, because of the many hidden input fields. Instead, I think we should just have 3 or four fields in the form:

                dragId, dropId, status (maybe dragStatus and dropStatus, if the two statuses can have different values for the same operation)

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19084 Fri Jul 17 18:05:11 MDT 2009 adnan.durrani Fix for ICE-4695 (Draggable panelGroups render excessive hidden input fields)
              Changes made so instead of rendering 2 hidden fields for each DND panelGroup, now the component renderes only one hidden field to a "form" regardless of number of DND panelGroups inside.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/dragdrop_custom.js
              Commit graph ADD /icefaces/trunk/icefaces/bridge/lib/extras/delimitedProperties.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19085 Fri Jul 17 18:06:14 MDT 2009 adnan.durrani Adding missing file. Related to the fix for ICE-4695
              Files Changed
              Commit graph ADD /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/util/DelimitedProperties.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19088 Mon Jul 20 12:14:17 MDT 2009 adnan.durrani js file added to the build file. Related to fix for ICE-4695
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/build.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19945 Thu Dec 10 14:36:52 MST 2009 judy.guglielmin ICE-4481 Did update for ICE-2614, 4080, 4803 and tested after each one--was good. After updating for ICE-4695, the scrollid in com.icesoft.faces.context.effects.DragDrop is coming back null. Note that CoreComponentsUtil is now used instead of D2DViewHandler for lookup of this id.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/conf/ice_properties/ice-panelGroup-props.xml
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/META-INF/resources/ice-extras.js
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/ExtendedAttributeConstants.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/effects/DragDrop.java
              Commit graph ADD /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/util/DelimitedProperties.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlPanelGroup.java

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Mark Collette
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: