Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:All
Description
Within the outputted div of every draggable or droppable ice:panelGroup are rendered two hidden input fields, for communicating back to the server:
<input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpstatus" id="iceform:_idiceform:PnlSrs:0:PnlGrpstatus"/>
<input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpdropID" id="iceform:_idiceform:PnlSrs:0:PnlGrpdropID"/>
That would really decrease performance, if there was a large table of draggable or droppable objects, because of the many hidden input fields. Instead, I think we should just have 3 or four fields in the form:
dragId, dropId, status (maybe dragStatus and dropStatus, if the two statuses can have different values for the same operation)
<input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpstatus" id="iceform:_idiceform:PnlSrs:0:PnlGrpstatus"/>
<input type="hidden" value="" name="iceform:_idiceform:PnlSrs:0:PnlGrpdropID" id="iceform:_idiceform:PnlSrs:0:PnlGrpdropID"/>
That would really decrease performance, if there was a large table of draggable or droppable objects, because of the many hidden input fields. Instead, I think we should just have 3 or four fields in the form:
dragId, dropId, status (maybe dragStatus and dropStatus, if the two statuses can have different values for the same operation)
Activity
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P2 |
Ken Fyten
made changes -
Fix Version/s | 1.8.2-RC1 [ 10210 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #19088 | Mon Jul 20 12:14:17 MDT 2009 | adnan.durrani | js file added to the build file. Related to fix for |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/bridge/build.xml
|
Adnan Durrani
made changes -
Link | This issue depends on ICE-4719 [ ICE-4719 ] |
Adnan Durrani
made changes -
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #19085 | Fri Jul 17 18:06:14 MDT 2009 | adnan.durrani | Adding missing file. Related to the fix for |
Files Changed | ||||
ADD
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/util/DelimitedProperties.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #19084 | Fri Jul 17 18:05:11 MDT 2009 | adnan.durrani | Fix for Changes made so instead of rendering 2 hidden fields for each DND panelGroup, now the component renderes only one hidden field to a "form" regardless of number of DND panelGroups inside. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/dragdrop_custom.js ADD /icefaces/trunk/icefaces/bridge/lib/extras/delimitedProperties.js |
Ken Fyten
made changes -
Salesforce Case | [] | |
Assignee Priority | P3 | P2 |
Adnan Durrani
made changes -
Link | This issue depends on ICE-4719 [ ICE-4719 ] |
Adnan Durrani
made changes -
Status | Open [ 1 ] | In Progress [ 3 ] |
Ken Fyten
made changes -
Salesforce Case | [] | |
Assignee | Mark Collette [ mark.collette ] | Adnan Durrani [ adnan.durrani ] |
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [] | |
Fix Version/s | 1.8.2 [ 10190 ] | |
Assignee Priority | P3 | |
Assignee | Mark Collette [ mark.collette ] |
Mark Collette
created issue -
Changes made so instead of rendering 2 hidden fields for each DND panelGroup, now the component renderes only one hidden field to a "form" regardless of number of DND panelGroups inside.
Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\dragdrop_custom.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\delimitedProperties.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Completed: At revision: 19084
Adding: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\util\DelimitedProperties.java
Completed: At revision: 19085