Details
Description
D2DViewHandler.getResourceURL is called frequently and is significantly more complex in implementation than the standard JSF version
Prior to the change (based on the optimization inICE-4057):
lifecycle took 9686000 RENDER: 8435000
lifecycle took 9514000 RENDER: 8344000
lifecycle took 9629000 RENDER: 8462000
lifecycle took 9473000 RENDER: 8282000
average:
after the change:
lifecycle took 7995000 RENDER: 6801000
lifecycle took 7584000 RENDER: 6419000
lifecycle took 7662000 RENDER: 6476000
lifecycle took 7659000 RENDER: 6501000
Comparing average times, this yields a 20% improvement.
Prior to the change (based on the optimization in
lifecycle took 9686000 RENDER: 8435000
lifecycle took 9514000 RENDER: 8344000
lifecycle took 9629000 RENDER: 8462000
lifecycle took 9473000 RENDER: 8282000
average:
after the change:
lifecycle took 7995000 RENDER: 6801000
lifecycle took 7584000 RENDER: 6419000
lifecycle took 7662000 RENDER: 6476000
lifecycle took 7659000 RENDER: 6501000
Comparing average times, this yields a 20% improvement.
Activity
Ted Goddard
created issue -
Ted Goddard
made changes -
Field | Original Value | New Value |
---|---|---|
Salesforce Case | [] | |
Fix Version/s | 1.8 [ 10161 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #18331 | Wed Feb 11 13:07:38 MST 2009 | ted.goddard | simplified getResourceURL ( |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletExternalContext.java
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/D2DViewHandler.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/PortletExternalContext.java |
Ken Fyten
made changes -
Salesforce Case | [] | |
Fix Version/s | 1.8RC1 [ 10143 ] | |
Fix Version/s | 1.8 [ 10161 ] |
Ken Fyten
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 1.8 [ 10161 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Checked in change assumes that the context path will not change during the lifetime of the ExternalContext.