ICEfaces
  1. ICEfaces
  2. ICE-3807

When I collapse a tree-node, it's icon doesn't move.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.7.2, 1.8DR#1
    • Fix Version/s: 1.8
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows Vista, Firefox 3.0, Jboss 4.2.3

      Description

      When a tree with a node with sub-nodes is created, in the source you can see a end line between the two images. This end line create a litle space between the two pictuce as you can see in the capture 1 of the showcase. For example in the tree of the iceFaces showcase at the first generation of the code :
      <div ...> <img src="tree_line_blank.gif"/> <a ...><img src="tree_nav_middle_close.gif" alt=""/></a>
      <div ...><img src="tree_folder_open.gif" .../></div>
      <div ...><a ...><span ...>Western</span></a></div>

      But now if you collapse and expand this same node, the code became :
      <div ...> <img src="tree_line_blank.gif"/> <a ...><img src="tree_nav_middle_close.gif" alt=""/></a><div ...><img src="tree_folder_open.gif" .../></div><div ...><a ...><span ...>Western</span></a></div>

      With the absence of end line, the space disappear and the icon in the tree move a little as you can see in the capture 2 of the showcase.
      1. DOMUtils.java
        28 kB
        Stephan Anft
      2. TreeRenderer.java
        30 kB
        Krashan Brahmanjara
      1. bad_tree.JPG
        12 kB
      2. err.PNG
        3 kB
      3. Nodes with children aren't aligned horizontally.jpg
        6 kB
      4. ScreenHunter_01 Mar. 26 13.59.jpg
        146 kB
      5. screenshot-1.jpg
        3 kB
      6. screenshot-2.jpg
        2 kB
      7. tree_folder_closed.gif
        1.0 kB

        Activity

        Hide
        Christophe Taverne added a comment - - edited

        Problem with icons horizontal align.
        See "test2" node that have children and other nodes.

        Show
        Christophe Taverne added a comment - - edited Problem with icons horizontal align. See "test2" node that have children and other nodes.
        Hide
        yip.ng added a comment -

        As this doesn't occur in component showcase anymore, it will be harder to debug and test. Please provide a simple test app. if possible.

        Show
        yip.ng added a comment - As this doesn't occur in component showcase anymore, it will be harder to debug and test. Please provide a simple test app. if possible.
        Hide
        Christophe Taverne added a comment - - edited

        Re,

        It doesn't occur in component showcase anymore simply because there isn't any node without children under the nodes with children into your example
        So we can't see this case.

        So simply add a node without children into the demo tree of component showcase and you will reproduce the problem as mentioned on this screen capture: http://jira.icefaces.org/secure/attachment/11633/Nodes+with+children+aren%27t+aligned+horizontally.jpg

        Thanks.

        regards

        Show
        Christophe Taverne added a comment - - edited Re, It doesn't occur in component showcase anymore simply because there isn't any node without children under the nodes with children into your example So we can't see this case. So simply add a node without children into the demo tree of component showcase and you will reproduce the problem as mentioned on this screen capture: http://jira.icefaces.org/secure/attachment/11633/Nodes+with+children+aren%27t+aligned+horizontally.jpg Thanks. regards
        Hide
        yip.ng added a comment -

        Fixed. See ScreenHunter_01 Mar. 26 13.59.jpg.

        Show
        yip.ng added a comment - Fixed. See ScreenHunter_01 Mar. 26 13.59.jpg.
        Hide
        Christophe Taverne added a comment -

        Perfect! Thanks a lot for your work.

        regards,

        Show
        Christophe Taverne added a comment - Perfect! Thanks a lot for your work. regards,

          People

          • Assignee:
            Unassigned
            Reporter:
            Loïc Villanné
          • Votes:
            5 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: