At the firts generation, you can see a little space created by the end line between the two balise

After a collapse and an expand of the node, the code is generated without endline between the two balise. The little space was destroyed between the two pictures.

I confirm the Issue also on Windows XP, FF 3.0 and IE6, and Tomcat 5.5.2x. It is present both in 1.7.0 and 1.7.1., but not in 1.6.2.
When the end-user expands/collapses a couple of nodes (he uses a little bit his application) the result is quite messy (see in bad_tree.jpg).

We have the same problem with the tree in a current project. After some investigation, it seems like the source of the problem is the line break handling in the DOMUtils class. Line breaks are processed differently for

(a) the children of the root node for the current DOM rendering and
(b) their children (= grandchildren of the root node).

The result is the behaviour described above: The first time the tree is rendered, the content of the tree nodes is handled like (b) because the root node of the rendering process is usually outside of the tree. Anyhow, as soon as a node is expanded, the content of the expanded tree node is handled like (a) because now the expanded node is the root node.

We have patched the DOMUtils class in order to adjust the line break handling. I have attached the modified source file. As far as I can see the problem is solved.

Please note that the changed DOMUtils class is based on the ICEFaces 1.7.2SP1 release so it may not fix the problem in other releases.

Works ok now, hopefully the patch can be applied in upcoming 1.8.0 version.

We have try this path on icefaces 1.7.2.3 ....and don't work.

This is a very noise problem for our application....
....we hope that icefaces 1.8 fix this issue.

ciao

Please. Describe that fix and show in diif ">"/"<" format on Jira

Error confirmed on 1.8.0 RC2

Hi,

I get this bug too with last SVN rév.

regards,

The problem is probably associated with java 1.6 or tomcat.
In ouput page I see sometimes malformed line end signs - instead 0A0D there are sometimes 0A0D0A, 0A or only 0D

Quick total fix is in DomUtils.java disable line with [ writer.write("\n"); ].

Another good fix is patch of TreeRenderer.java at row 433

(431) navAnchor.setAttribute(HTML.ONCLICK_ATTR, onclickString);
treeNodeDiv.appendChild(navAnchor);
> repair new line problem in component-showcase main menu
> Text space = domContext.createTextNode(" ");
> treeNodeDiv.appendChild(space);
// icon

Above patch do not resolve problem with line breaking between icon and label in tree example from component-showcase.

Also file tree_folder_closed.gif in rime style got invalid size. Patch in attachment

Corrected tree_folder_closed.gif for rime style

Patched TreeRenderer

BTW
Patch of DomUtils.java from attachment of Stephen Anpf is not necessary.

Hi,

a part of bug still remains on last SVN rev: 18662.

Nodes with children and nodes without children that are not aligned horizontally. A space character is always here into the generated code.

We can't see this case on the component showcase. So please, see my new attached picture.

regards,

Problem with icons horizontal align.
See "test2" node that have children and other nodes.

As this doesn't occur in component showcase anymore, it will be harder to debug and test. Please provide a simple test app. if possible.

Re,

It doesn't occur in component showcase anymore simply because there isn't any node without children under the nodes with children into your example
So we can't see this case.

So simply add a node without children into the demo tree of component showcase and you will reproduce the problem as mentioned on this screen capture: http://jira.icefaces.org/secure/attachment/11633/Nodes+with+children+aren%27t+aligned+horizontally.jpg

Thanks.

regards

Fixed. See ScreenHunter_01 Mar. 26 13.59.jpg.

Perfect! Thanks a lot for your work.

regards,