ICEfaces
  1. ICEfaces
  2. ICE-3591

Add double click support on dataTable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8RC2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      There has been a few requests for the inclusion of double-click support for the dataTable component. Ideally this would be functional with the single-click on the row selection, as in have another action listener called when a row is double clicked.

        Activity

        Hide
        Arturo Zambrano added a comment -

        Committed to revision 18584

        Show
        Arturo Zambrano added a comment - Committed to revision 18584
        Hide
        Ken Fyten added a comment -

        It'd be easier for developers to use our custom events (RowSelectorEvent and ClickEvent), since they already have convenience methods to find out the row that was clicked/selected, whether the row is selected or not, and if the event was a single or a double click.

        It would also be better to have a consistent naming pattern. I also noticed that RowSelectorEvent (and ClickEvent) extends FacesEvent and not ActionEvent. I don't see why it shouldn't extend ActionEvent instead of FacesEvent. After all, ActionEvent extends FacesEvent, and selectionListener is actually what in JSF is known as an 'action listener', whose signature is of the form 'public void listener(ActionEvent event)'. I think this is more consistent with JSF. Finally, to be more consistent with our other events I think they should all contain the word 'Action' in it.

        Show
        Ken Fyten added a comment - It'd be easier for developers to use our custom events (RowSelectorEvent and ClickEvent), since they already have convenience methods to find out the row that was clicked/selected, whether the row is selected or not, and if the event was a single or a double click. It would also be better to have a consistent naming pattern. I also noticed that RowSelectorEvent (and ClickEvent) extends FacesEvent and not ActionEvent. I don't see why it shouldn't extend ActionEvent instead of FacesEvent. After all, ActionEvent extends FacesEvent, and selectionListener is actually what in JSF is known as an 'action listener', whose signature is of the form 'public void listener(ActionEvent event)'. I think this is more consistent with JSF. Finally, to be more consistent with our other events I think they should all contain the word 'Action' in it.

          People

          • Assignee:
            Unassigned
            Reporter:
            Arran Mccullough
          • Votes:
            11 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: