ICEfaces
  1. ICEfaces
  2. ICE-3591

Add double click support on dataTable

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8RC2, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            There has been a few requests for the inclusion of double-click support for the dataTable component. Ideally this would be functional with the single-click on the row selection, as in have another action listener called when a row is double clicked.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Support Customer Ref. #s https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=5230
              Arran Mccullough made changes -
              Salesforce Case [50070000007C5TH]
              Stefan Zeller made changes -
              Salesforce Case [50070000007C5TH] [50070000007C5TH, 5007000000803SC]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial]
              Assignee Priority P2
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Fix Version/s 1.8RC2 [ 10163 ]
              Fix Version/s 1.8 [ 10161 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18584 Mon Mar 16 13:02:56 MDT 2009 art.zambrano ICE-3591 Add double click support on dataTable
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
              Commit graph ADD /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/ClickEvent.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml
              Commit graph ADD /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/ClickActionEvent.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/java/com/icesoft/metadata/generators/TagLibraryGenerator.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18591 Mon Mar 16 17:29:15 MDT 2009 art.zambrano ICE-3591 (added dblClickDelay attribute to rowSelector)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed to revision 18584

              Show
              Arturo Zambrano added a comment - Committed to revision 18584
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18595 Tue Mar 17 16:20:59 MDT 2009 art.zambrano ICE-3591 (disable text selection when enhancedMultiple=true OR clickLsitener OR clickAction)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Hide
              Permalink
              Ken Fyten added a comment -

              It'd be easier for developers to use our custom events (RowSelectorEvent and ClickEvent), since they already have convenience methods to find out the row that was clicked/selected, whether the row is selected or not, and if the event was a single or a double click.

              It would also be better to have a consistent naming pattern. I also noticed that RowSelectorEvent (and ClickEvent) extends FacesEvent and not ActionEvent. I don't see why it shouldn't extend ActionEvent instead of FacesEvent. After all, ActionEvent extends FacesEvent, and selectionListener is actually what in JSF is known as an 'action listener', whose signature is of the form 'public void listener(ActionEvent event)'. I think this is more consistent with JSF. Finally, to be more consistent with our other events I think they should all contain the word 'Action' in it.

              Show
              Ken Fyten added a comment - It'd be easier for developers to use our custom events (RowSelectorEvent and ClickEvent), since they already have convenience methods to find out the row that was clicked/selected, whether the row is selected or not, and if the event was a single or a double click. It would also be better to have a consistent naming pattern. I also noticed that RowSelectorEvent (and ClickEvent) extends FacesEvent and not ActionEvent. I don't see why it shouldn't extend ActionEvent instead of FacesEvent. After all, ActionEvent extends FacesEvent, and selectionListener is actually what in JSF is known as an 'action listener', whose signature is of the form 'public void listener(ActionEvent event)'. I think this is more consistent with JSF. Finally, to be more consistent with our other events I think they should all contain the word 'Action' in it.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18605 Wed Mar 18 15:11:20 MDT 2009 art.zambrano ICE-3591 (fixed issue with not being able to focus input elements when preventing text selection)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18609 Wed Mar 18 16:26:31 MDT 2009 art.zambrano ICE-3591 (renamed click event)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Commit graph DEL /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/ClickEvent.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/ClickActionEvent.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/java/com/icesoft/metadata/generators/TagLibraryGenerator.java
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18655 Wed Mar 25 14:31:58 MDT 2009 art.zambrano ICE-3591 removed comments
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P2
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Arturo Zambrano [ artzambrano ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Arran Mccullough
                • Votes:
                  11 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: