ICEfaces
  1. ICEfaces
  2. ICE-3483

Regression: Fix the passThru boolean attributes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.2
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      component + passThru boolean attributes

      Description

      To avoid the unnecessary calls , the new approach taken to rendering of the passThru attributes, doesn't render the booleanPassThru attributes by default. So any component which supports any boolean attribute has to make the following call from the renderer exclusively,

      For DOM based renderer:
             PassThruAttributeRenderer.renderBooleanAttributes(
                       facesContext,
                       uiComponent,
                       targetElement,
                        excludedAttributes)

      For ResponseWriter based renderer:
              PassThruAttributeWriter.renderBooleanAttributes(
                      writer,
                      uiComponent,
                      excludedAttributes);


      The call should go to those component only, which support one of a following boolean attribute.
              - disabled
              - ismap
              - readonly

        
      1. disabled_Renderer.txt
        3 kB
        Frank Ye
      2. readonly_renderer.txt
        2 kB
        Frank Ye

        Activity

        Hide
        Mark Collette added a comment -

        http://www.icefaces.org/JForum/posts/list/9652.page#40126

        The forum poster mentioned InputText not doing disabled and readonly properly. The decode is properly checking them, to know to not decode, but the rendering was not emitting the proper markup, allowing the user to enter values into the input field. CSS styling was working properly though.

        Show
        Mark Collette added a comment - http://www.icefaces.org/JForum/posts/list/9652.page#40126 The forum poster mentioned InputText not doing disabled and readonly properly. The decode is properly checking them, to know to not decode, but the rendering was not emitting the proper markup, allowing the user to enter values into the input field. CSS styling was working properly though.
        Hide
        Frank Ye added a comment -

        Renderer with disabled attribute

        Show
        Frank Ye added a comment - Renderer with disabled attribute
        Hide
        Frank Ye added a comment -

        Renderer with readonly attribute

        Show
        Frank Ye added a comment - Renderer with readonly attribute
        Hide
        Adnan Durrani added a comment -

        Its preferred that we should make both calls one after each other. Easier to maintain.
        PassThruAttributeWriter.renderHtmlAttributes(writer, uiComponent, passThruAttributes);
        PassThruAttributeWriter.renderBooleanAttributes(writer, uiComponent, excludedAttributes);

        Show
        Adnan Durrani added a comment - Its preferred that we should make both calls one after each other. Easier to maintain. PassThruAttributeWriter.renderHtmlAttributes(writer, uiComponent, passThruAttributes); PassThruAttributeWriter.renderBooleanAttributes(writer, uiComponent, excludedAttributes);
        Hide
        Adnan Durrani added a comment -

        Yes, boolean were not working on the inputText. We fixed it yesterday.

        http://jira.icefaces.org/browse/ICE-3321

        Show
        Adnan Durrani added a comment - Yes, boolean were not working on the inputText. We fixed it yesterday. http://jira.icefaces.org/browse/ICE-3321
        Hide
        Mark Collette added a comment -

        Some forum posting mentioned commandButton's disabled not working.

        Show
        Mark Collette added a comment - Some forum posting mentioned commandButton's disabled not working.
        Hide
        Adnan Durrani added a comment -

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
        Completed: At revision: 17773

        Show
        Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java Completed: At revision: 17773
        Hide
        Adnan Durrani added a comment -

        trunk revision 17774

        Show
        Adnan Durrani added a comment - trunk revision 17774

          People

          • Assignee:
            Unassigned
            Reporter:
            Adnan Durrani
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: