ICEfaces
  1. ICEfaces
  2. ICE-3483

Regression: Fix the passThru boolean attributes

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2
          • Fix Version/s: 1.8DR#2, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            component + passThru boolean attributes

            Description

            To avoid the unnecessary calls , the new approach taken to rendering of the passThru attributes, doesn't render the booleanPassThru attributes by default. So any component which supports any boolean attribute has to make the following call from the renderer exclusively,

            For DOM based renderer:
                   PassThruAttributeRenderer.renderBooleanAttributes(
                             facesContext,
                             uiComponent,
                             targetElement,
                              excludedAttributes)

            For ResponseWriter based renderer:
                    PassThruAttributeWriter.renderBooleanAttributes(
                            writer,
                            uiComponent,
                            excludedAttributes);


            The call should go to those component only, which support one of a following boolean attribute.
                    - disabled
                    - ismap
                    - readonly

              
            1. Text File
              disabled_Renderer.txt
              3 kB
              Frank Ye
            2. Text File
              readonly_renderer.txt
              2 kB
              Frank Ye

              Activity

              Ascending order - Click to sort in descending order
              Adnan Durrani created issue -
              Hide
              Permalink
              Mark Collette added a comment -

              http://www.icefaces.org/JForum/posts/list/9652.page#40126

              The forum poster mentioned InputText not doing disabled and readonly properly. The decode is properly checking them, to know to not decode, but the rendering was not emitting the proper markup, allowing the user to enter values into the input field. CSS styling was working properly though.

              Show
              Mark Collette added a comment - http://www.icefaces.org/JForum/posts/list/9652.page#40126 The forum poster mentioned InputText not doing disabled and readonly properly. The decode is properly checking them, to know to not decode, but the rendering was not emitting the proper markup, allowing the user to enter values into the input field. CSS styling was working properly though.
              Hide
              Permalink
              Frank Ye added a comment -

              Renderer with disabled attribute

              Show
              Frank Ye added a comment - Renderer with disabled attribute
              Frank Ye made changes -
              Field Original Value New Value
              Attachment disabled_Renderer.txt [ 11225 ]
              Hide
              Permalink
              Frank Ye added a comment -

              Renderer with readonly attribute

              Show
              Frank Ye added a comment - Renderer with readonly attribute
              Frank Ye made changes -
              Attachment readonly_renderer.txt [ 11226 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Its preferred that we should make both calls one after each other. Easier to maintain.
              PassThruAttributeWriter.renderHtmlAttributes(writer, uiComponent, passThruAttributes);
              PassThruAttributeWriter.renderBooleanAttributes(writer, uiComponent, excludedAttributes);

              Show
              Adnan Durrani added a comment - Its preferred that we should make both calls one after each other. Easier to maintain. PassThruAttributeWriter.renderHtmlAttributes(writer, uiComponent, passThruAttributes); PassThruAttributeWriter.renderBooleanAttributes(writer, uiComponent, excludedAttributes);
              Hide
              Permalink
              Adnan Durrani added a comment -

              Yes, boolean were not working on the inputText. We fixed it yesterday.

              http://jira.icefaces.org/browse/ICE-3321

              Show
              Adnan Durrani added a comment - Yes, boolean were not working on the inputText. We fixed it yesterday. http://jira.icefaces.org/browse/ICE-3321
              Ken Fyten made changes -
              Fix Version/s 1.7.2 [ 10130 ]
              Affects Version/s 1.7.2 [ 10130 ]
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Fix Version/s 1.8DR#1 [ 10141 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Assignee Priority P2
              Assignee Ken Fyten [ ken.fyten ] Adnan Durrani [ adnan.durrani ]
              Hide
              Permalink
              Mark Collette added a comment -

              Some forum posting mentioned commandButton's disabled not working.

              Show
              Mark Collette added a comment - Some forum posting mentioned commandButton's disabled not working.
              Ken Fyten made changes -
              Fix Version/s 1.8DR#2 [ 10142 ]
              Fix Version/s 1.8DR#1 [ 10141 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17773 Tue Oct 14 19:22:50 MDT 2008 adnan.durrani Fix related to ICE-3483 (Regression: Fix the passThru boolean attributes)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/SelectManyCheckboxListRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/RadioRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CheckboxRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17774 Tue Oct 14 21:17:26 MDT 2008 adnan.durrani Fix related to ICE-3483 (Regression: Fix the passThru boolean attributes)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/ButtonRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java
              Completed: At revision: 17773

              Show
              Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\RadioRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CheckboxRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\SelectManyCheckboxListRenderer.java Completed: At revision: 17773
              Hide
              Permalink
              Adnan Durrani added a comment -

              trunk revision 17774

              Show
              Adnan Durrani added a comment - trunk revision 17774
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.8 [ 10161 ]
              Assignee Priority P2
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Adnan Durrani [ adnan.durrani ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Adnan Durrani
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: