ICEfaces
  1. ICEfaces
  2. ICE-3442

Component saveState restoreState

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      any

      Description

      saveState and restoreState with components

        Issue Links

          Activity

          Hide
          Frank Ye added a comment -

          state saving

          Show
          Frank Ye added a comment - state saving
          Hide
          Frank Ye added a comment -

          Mock container is created for a few tests to audit the current situations related to component saveState and restoreState.

          #1. Using StateManageImpl from jsf12 to confirm the specific properties
          #2. Using MockSerializedView to store tree as well as state for wirteObject and readObject procedure

          Show
          Frank Ye added a comment - Mock container is created for a few tests to audit the current situations related to component saveState and restoreState. #1. Using StateManageImpl from jsf12 to confirm the specific properties #2. Using MockSerializedView to store tree as well as state for wirteObject and readObject procedure
          Hide
          Ken Fyten added a comment -

          Need to manually review each component to ensure state-saving of each component's fields is being done correctly.

          Subsequently need to generate automated tests to ensure state-saving is working in an on-going basis.

          Show
          Ken Fyten added a comment - Need to manually review each component to ensure state-saving of each component's fields is being done correctly. Subsequently need to generate automated tests to ensure state-saving is working in an on-going basis.
          Hide
          Frank Ye added a comment -

          mock tests

          Show
          Frank Ye added a comment - mock tests
          Hide
          Adnan Durrani added a comment -

          save/restore state fixed for the required properties of the following components.

          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java
          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java
          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java
          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java
          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
          Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java
          Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java
          Completed: At revision: 17531

          Show
          Adnan Durrani added a comment - save/restore state fixed for the required properties of the following components. Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java Modified: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlForm.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessage.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlMessages.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlOutputFormat.java Sending content: D:\work\development\freshcopy\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyListbox.java Completed: At revision: 17531
          Hide
          Mark Collette added a comment -

          Subversion 17535
          icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyMenu.java
          Subversion 17536
          icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneListbox.java
          Subversion 17537
          icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneMenu.java
          Subversion 17540
          icefaces\component\src\com\icesoft\faces\component\style\OutputStyle.java
          icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java

          Show
          Mark Collette added a comment - Subversion 17535 icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectManyMenu.java Subversion 17536 icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneListbox.java Subversion 17537 icefaces\component\src\com\icesoft\faces\component\ext\HtmlSelectOneMenu.java Subversion 17540 icefaces\component\src\com\icesoft\faces\component\style\OutputStyle.java icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java
          Hide
          Mark Collette added a comment -

          Subversion 17541
          icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java

          Show
          Mark Collette added a comment - Subversion 17541 icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java
          Hide
          Mark Collette added a comment -

          TRUNK
          Subversion 17707
          icefaces\component\src\com\icesoft\faces\component\ext\HeaderRow.java
          icefaces\component\src\com\icesoft\faces\component\ext\HtmlCommandButton.java
          icefaces\component\src\com\icesoft\faces\component\outputprogress\OutputProgress.java
          icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorder.java
          icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsible.java
          icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java
          icefaces\component\src\com\icesoft\faces\component\portlet\Portlet.java

          Show
          Mark Collette added a comment - TRUNK Subversion 17707 icefaces\component\src\com\icesoft\faces\component\ext\HeaderRow.java icefaces\component\src\com\icesoft\faces\component\ext\HtmlCommandButton.java icefaces\component\src\com\icesoft\faces\component\outputprogress\OutputProgress.java icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorder.java icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsible.java icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java icefaces\component\src\com\icesoft\faces\component\portlet\Portlet.java
          Hide
          Mark Collette added a comment -

          In order to save and restore the state for OutputChart, I had to make some changes to how it managed its image resource.

          TRUNK
          Subversion 17713
          icefaces\component\src\com\icesoft\faces\component\outputchart\AbstractChart.java
          icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java
          icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java
          icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java

          Show
          Mark Collette added a comment - In order to save and restore the state for OutputChart, I had to make some changes to how it managed its image resource. TRUNK Subversion 17713 icefaces\component\src\com\icesoft\faces\component\outputchart\AbstractChart.java icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java
          Hide
          Adnan Durrani added a comment -

          Trunk revision: 17799 [MockTestCase is using our own MockExternalContext]

          Show
          Adnan Durrani added a comment - Trunk revision: 17799 [MockTestCase is using our own MockExternalContext]
          Hide
          Mark Collette added a comment -

          Starting to fix failures found with ICE-3696's test.

          TRUNK
          Subversion 17832
          icefaces\component\src\com\icesoft\faces\component\ext\UIColumn.java
          icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java

          Show
          Mark Collette added a comment - Starting to fix failures found with ICE-3696 's test. TRUNK Subversion 17832 icefaces\component\src\com\icesoft\faces\component\ext\UIColumn.java icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java
          Hide
          Mark Collette added a comment -

          For ICE-3696's test to work properly, the following classes had to be augmented to properly implement a deep version of Object.equals(Object). Resource, UpdatableProperty, Effect, CurrentStyle.

          TRUNK
          Subversion 17847
          icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java
          icefaces\component\src\com\icesoft\faces\utils\UpdatableProperty.java
          icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java
          icefaces\core\src\com\icesoft\faces\context\effects\Fade.java
          icefaces\core\src\com\icesoft\faces\context\effects\Puff.java
          icefaces\core\src\com\icesoft\faces\context\effects\EffectQueue.java
          icefaces\core\src\com\icesoft\faces\context\effects\CurrentStyle.java
          icefaces\core\src\com\icesoft\faces\context\effects\Appear.java
          icefaces\core\src\com\icesoft\faces\context\effects\Squish.java
          icefaces\core\src\com\icesoft\faces\context\effects\Grow.java
          icefaces\core\src\com\icesoft\faces\context\effects\Focus.java
          icefaces\core\src\com\icesoft\faces\context\effects\BlindDown.java
          icefaces\core\src\com\icesoft\faces\context\effects\Scale.java
          icefaces\core\src\com\icesoft\faces\context\effects\SlideDown.java
          icefaces\core\src\com\icesoft\faces\context\effects\Shake.java
          icefaces\core\src\com\icesoft\faces\context\effects\DropOut.java
          icefaces\core\src\com\icesoft\faces\context\effects\SwitchOff.java
          icefaces\core\src\com\icesoft\faces\context\effects\BlindUp.java
          icefaces\core\src\com\icesoft\faces\context\effects\BlankEffect.java
          icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
          icefaces\core\src\com\icesoft\faces\context\effects\SlideUp.java
          icefaces\core\src\com\icesoft\faces\context\effects\Move.java
          icefaces\core\src\com\icesoft\faces\context\effects\Highlight.java
          icefaces\core\src\com\icesoft\faces\context\effects\Opacity.java
          icefaces\core\src\com\icesoft\faces\context\effects\Pulsate.java
          icefaces\core\src\com\icesoft\faces\context\effects\Fold.java
          icefaces\core\src\com\icesoft\faces\context\effects\Effect.java
          icefaces\core\src\com\icesoft\faces\context\effects\Shrink.java
          icefaces\core\src\com\icesoft\faces\util\CoreUtils.java

          Show
          Mark Collette added a comment - For ICE-3696 's test to work properly, the following classes had to be augmented to properly implement a deep version of Object.equals(Object). Resource, UpdatableProperty, Effect, CurrentStyle. TRUNK Subversion 17847 icefaces\component\src\com\icesoft\faces\component\outputchart\ChartResource.java icefaces\component\src\com\icesoft\faces\utils\UpdatableProperty.java icefaces\core\src\com\icesoft\faces\context\ByteArrayResource.java icefaces\core\src\com\icesoft\faces\context\effects\Fade.java icefaces\core\src\com\icesoft\faces\context\effects\Puff.java icefaces\core\src\com\icesoft\faces\context\effects\EffectQueue.java icefaces\core\src\com\icesoft\faces\context\effects\CurrentStyle.java icefaces\core\src\com\icesoft\faces\context\effects\Appear.java icefaces\core\src\com\icesoft\faces\context\effects\Squish.java icefaces\core\src\com\icesoft\faces\context\effects\Grow.java icefaces\core\src\com\icesoft\faces\context\effects\Focus.java icefaces\core\src\com\icesoft\faces\context\effects\BlindDown.java icefaces\core\src\com\icesoft\faces\context\effects\Scale.java icefaces\core\src\com\icesoft\faces\context\effects\SlideDown.java icefaces\core\src\com\icesoft\faces\context\effects\Shake.java icefaces\core\src\com\icesoft\faces\context\effects\DropOut.java icefaces\core\src\com\icesoft\faces\context\effects\SwitchOff.java icefaces\core\src\com\icesoft\faces\context\effects\BlindUp.java icefaces\core\src\com\icesoft\faces\context\effects\BlankEffect.java icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java icefaces\core\src\com\icesoft\faces\context\effects\SlideUp.java icefaces\core\src\com\icesoft\faces\context\effects\Move.java icefaces\core\src\com\icesoft\faces\context\effects\Highlight.java icefaces\core\src\com\icesoft\faces\context\effects\Opacity.java icefaces\core\src\com\icesoft\faces\context\effects\Pulsate.java icefaces\core\src\com\icesoft\faces\context\effects\Fold.java icefaces\core\src\com\icesoft\faces\context\effects\Effect.java icefaces\core\src\com\icesoft\faces\context\effects\Shrink.java icefaces\core\src\com\icesoft\faces\util\CoreUtils.java

            People

            • Assignee:
              Unassigned
              Reporter:
              Frank Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: