ICEfaces
  1. ICEfaces
  2. ICE-3303

Make InputFile's FileInfo Serializable

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8DR#2, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            User needs InputFile's FileInfo to be Serializable.

              Issue Links

              blocks

              New Feature - A new feature of the product, which has yet to be developed. ICE-3696 Test component field state saving

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3442 Component saveState restoreState

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Mark Collette added a comment -

                While making all fields of FileInfo be serialized, make sure InputFile.uploadException is too. Specifically, see if the commons-upload, or any other, Exceptions are Serializable, so that the FacesMessages will still be properly generated.

                Show
                Mark Collette added a comment - While making all fields of FileInfo be serialized, make sure InputFile.uploadException is too. Specifically, see if the commons-upload, or any other, Exceptions are Serializable, so that the FacesMessages will still be properly generated.
                Hide
                Permalink
                yip.ng added a comment -

                FileInfo already implements Serializable.

                Added equals() method.

                FileInfo.exception is either an org.apache.commons.fileupload.FileUploadBase.FileUploadIOException or a java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable.

                InputFile.uploadException is either an org.apache.commons.fileupload.FileUploadException or java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable.

                Other Commons File Upload exceptions also inherit from Throwable. Therefore they are already serializable.

                Show
                yip.ng added a comment - FileInfo already implements Serializable. Added equals() method. FileInfo.exception is either an org.apache.commons.fileupload.FileUploadBase.FileUploadIOException or a java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable. InputFile.uploadException is either an org.apache.commons.fileupload.FileUploadException or java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable. Other Commons File Upload exceptions also inherit from Throwable. Therefore they are already serializable.
                Hide
                Permalink
                yip.ng added a comment -

                Added util method to compare Throwables and called it from FileInfo equals() method to compare FileInfo.exception.

                Show
                yip.ng added a comment - Added util method to compare Throwables and called it from FileInfo equals() method to compare FileInfo.exception.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: