ICEfaces
  1. ICEfaces
  2. ICE-3666

Non serialized properties of the components need to be defined as transient

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Non serialized properties + transient

      Description

      Non serialized properties of the components need to be defined as transient

        Issue Links

          Activity

          Hide
          Adnan Durrani added a comment -

          HtmlPanelGroup.java
          HtmlRadio.java
          HtmlSelectBooleanCheckbox.java
          HtmlSelectManyCheckbox.java
          HtmlSelectManyListbox.java
          HtmlSelectManyMenu.java
          HtmlSelectOneListbox.java
          HtmlSelectOneMenu.java
          HtmlSelectOneRadio.java
          OutputBody.java
          OutputHead.java
          OutputHtml.java
          RowSelector.java
          UIColumn.java
          UIColumns.java

          From all above classes only 3 transient properties are identified. Trunk revision 17809

          Show
          Adnan Durrani added a comment - HtmlPanelGroup.java HtmlRadio.java HtmlSelectBooleanCheckbox.java HtmlSelectManyCheckbox.java HtmlSelectManyListbox.java HtmlSelectManyMenu.java HtmlSelectOneListbox.java HtmlSelectOneMenu.java HtmlSelectOneRadio.java OutputBody.java OutputHead.java OutputHtml.java RowSelector.java UIColumn.java UIColumns.java From all above classes only 3 transient properties are identified. Trunk revision 17809
          Hide
          Adnan Durrani added a comment -

          panelborder
          panelcollapsible
          paneldivider
          panellayout
          panelpopup
          panelpositioned
          panelseries
          panelstack
          paneltabset
          paneltooltip
          selectinputdate
          selectinputtext
          style
          tree

          From all above classes, only following class required some adjustment.
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputtext\SelectInputText.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputtext\SelectInputText.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java
          Completed: At revision: 17812

          Show
          Adnan Durrani added a comment - panelborder panelcollapsible paneldivider panellayout panelpopup panelpositioned panelseries panelstack paneltabset paneltooltip selectinputdate selectinputtext style tree From all above classes, only following class required some adjustment. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputtext\SelectInputText.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputtext\SelectInputText.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneldivider\PanelDivider.java Completed: At revision: 17812
          Hide
          yip.ng added a comment -

          Went thru:

          ColumnGroup
          HeaderRow
          HtmlCheckbox
          HtmlcommandButton
          HtmlcommandLinkHtml
          HtmlDataTable
          Htmlform
          HtmlGraphicImage
          HtmlInputHidden
          HtmlInputSecret
          HtmlInputText
          HtmlInputTextarea
          HtmlMessage
          HtmlMessages
          HtmlOutputFormat
          HtmlOutputLabel
          HtmlOutputLink
          HtmlOutputText
          HtmlPanelGrid
          commandsortheader
          datapaginator
          dragdrop
          gmap
          inputfile
          inputrichtext
          menubar
          menupopup
          outputchart
          outputconnectionstatus
          outputdeclaration
          outputmedia
          outputprogress
          outputresource

          Only following have changes:

          DataPaginator
          GMap
          HtmlDataTable
          OutputChart
          OutputResource

          Show
          yip.ng added a comment - Went thru: ColumnGroup HeaderRow HtmlCheckbox HtmlcommandButton HtmlcommandLinkHtml HtmlDataTable Htmlform HtmlGraphicImage HtmlInputHidden HtmlInputSecret HtmlInputText HtmlInputTextarea HtmlMessage HtmlMessages HtmlOutputFormat HtmlOutputLabel HtmlOutputLink HtmlOutputText HtmlPanelGrid commandsortheader datapaginator dragdrop gmap inputfile inputrichtext menubar menupopup outputchart outputconnectionstatus outputdeclaration outputmedia outputprogress outputresource Only following have changes: DataPaginator GMap HtmlDataTable OutputChart OutputResource
          Hide
          Mark Collette added a comment -

          In the places where we cache the Object[] values for saveState and restoreState, mark Object[] values as transient.

          TRUNK
          Subversion 17829
          icefaces\component\src\com\icesoft\faces\component\effect\ApplyEffect.java
          icefaces\component\src\com\icesoft\faces\component\ext\ColumnGroup.java
          icefaces\component\src\com\icesoft\faces\component\ext\UIColumns.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java
          icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java
          icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java
          icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorder.java
          icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java
          icefaces\component\src\com\icesoft\faces\component\panelseries\PanelSeries.java
          icefaces\component\src\com\icesoft\faces\component\panelstack\PanelStack.java
          icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java
          icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java
          icefaces\component\src\com\icesoft\faces\component\portlet\Portlet.java

          Show
          Mark Collette added a comment - In the places where we cache the Object[] values for saveState and restoreState, mark Object[] values as transient. TRUNK Subversion 17829 icefaces\component\src\com\icesoft\faces\component\effect\ApplyEffect.java icefaces\component\src\com\icesoft\faces\component\ext\ColumnGroup.java icefaces\component\src\com\icesoft\faces\component\ext\UIColumns.java icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java icefaces\component\src\com\icesoft\faces\component\panelborder\PanelBorder.java icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java icefaces\component\src\com\icesoft\faces\component\panelseries\PanelSeries.java icefaces\component\src\com\icesoft\faces\component\panelstack\PanelStack.java icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTab.java icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java icefaces\component\src\com\icesoft\faces\component\portlet\Portlet.java
          Hide
          Adnan Durrani added a comment -

          Found after running the SerializedViewFieldTest.

          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java
          Completed: At revision: 17834

          Show
          Adnan Durrani added a comment - Found after running the SerializedViewFieldTest. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMap.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java Completed: At revision: 17834
          Hide
          Adnan Durrani added a comment -

          Found after running the SerializedViewFieldTest.

          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\OutputHtml.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpositioned\PanelPositioned.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\OutputHtml.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpositioned\PanelPositioned.java
          Completed: At revision: 17836

          Show
          Adnan Durrani added a comment - Found after running the SerializedViewFieldTest. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\OutputHtml.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpositioned\PanelPositioned.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\OutputHtml.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopup.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panellayout\PanelLayout.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpositioned\PanelPositioned.java Completed: At revision: 17836
          Hide
          Adnan Durrani added a comment -

          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\tree\Tree.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\tree\Tree.java
          Completed: At revision: 17840

          Show
          Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\tree\Tree.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\tree\Tree.java Completed: At revision: 17840
          Hide
          Joanne Bai added a comment -

          tested successfully on trunk @revision 17955

          Show
          Joanne Bai added a comment - tested successfully on trunk @revision 17955

            People

            • Assignee:
              Unassigned
              Reporter:
              Adnan Durrani
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: