Details
-
Type: Improvement
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7
-
Fix Version/s: 1.7.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:any uses of selectOneRadio
Description
The selectOneRadio renderer uses a HTML table element to layout its child components. The table element does not specify either cellpadding or cellspacing attributes which make styling the component difficult. Both cellpadding and cellspacing default to 1px which means that the selectOneRadio component will be offset as much as 4px in the vertical with any label on the same plain.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
Issue Links
- is duplicated by
-
ICE-6689 CLONE -selectOneRadio renders a table with default cell padding and spacing
- Closed
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #16817 | Thu Jun 05 17:07:10 MDT 2008 | yip.ng | Set cellpadding and cellspacing of table containing radio buttons to "0". |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/RadioRenderer.java MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #16816 | Thu Jun 05 17:02:29 MDT 2008 | yip.ng | Set cellpadding and cellspacing of table containing radio buttons to "0". |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/RadioRenderer.java
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css |