Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7
-
Fix Version/s: 1.7.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:any uses of selectOneRadio
Description
The selectOneRadio renderer uses a HTML table element to layout its child components. The table element does not specify either cellpadding or cellspacing attributes which make styling the component difficult. Both cellpadding and cellspacing default to 1px which means that the selectOneRadio component will be offset as much as 4px in the vertical with any label on the same plain.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
Issue Links
- is duplicated by
-
ICE-6689
CLONE -selectOneRadio renders a table with default cell padding and spacing
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
I suspect the margin: 1px maybe causing this. Can you confirm?
Show
Patrick Corless
added a comment - I suspect the margin: 1px maybe causing this. Can you confirm?
The margin property doesn't seem to have any effect on the layout. I tried changing it to a large value, but the layout remained the same. Also, the default value was "0" in Firefox and "auto" in IE. So, if it is for backwards compatibility, we should probably just leave it out.
Show
yip.ng
added a comment - The margin property doesn't seem to have any effect on the layout. I tried changing it to a large value, but the layout remained the same. Also, the default value was "0" in Firefox and "auto" in IE. So, if it is for backwards compatibility, we should probably just leave it out.
In order to maintain complete backwards compatiblitiy with the existing rendering and component spacing we could add the padding back into our default theme style sheets so that we don't mess up any existing applications.
The new rule would likely look like:
.iceSelOneRb table tr td
{ padding: 1px; margin: 1px; }