Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Duplicate
-
Affects Version/s: 2.0.0
-
Fix Version/s: 3.0, EE-3.0.0.GA
-
Component/s: ICE-Components
-
Labels:None
-
Environment:any uses of selectOneRadio
-
Affects:Compatibility/Configuration
Description
The selectOneRadio renderer uses a HTML table element to layout its child components. The table element does not specify either cellpadding or cellspacing attributes which make styling the component difficult. Both cellpadding and cellspacing default to 1px which means that the selectOneRadio component will be offset as much as 4px in the vertical with any label on the same plain.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.
Issue Links
- duplicates
-
ICE-3140
selectOneRadio renders a table with default cell padding and spacing
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The change for ICE-3140 was to remove some CSS styling we had that was setting padding to 1px:
.iceSelOneRb table tr td {
+ 98 + padding: 1px;
+ 99 + }
However, now we are letting default padding occur, which according to this JIRA, is 1px in some browsers. So we don't want to mess with backwards compatibility, so we need an optional way for folks to remove this padding if they want. Why can't they do this with simple CSS that they could apply to the component or customize the theme with?
Show
Ken Fyten
added a comment - The change for ICE-3140 was to remove some CSS styling we had that was setting padding to 1px:
.iceSelOneRb table tr td {
+ 98 + padding: 1px;
+ 99 + }
However, now we are letting default padding occur, which according to this JIRA, is 1px in some browsers. So we don't want to mess with backwards compatibility, so we need an optional way for folks to remove this padding if they want. Why can't they do this with simple CSS that they could apply to the component or customize the theme with?
NO. The change was to ADD the CSS because we changed the cell padding and spacing as the user requested. Please see attached screenshot-01.png and screenshot-02.png.
This was already done a long time ago in
ICE-3140. The changes are in both icefaces 3 and icefaces 3.0.x maintenance.