ICEfaces
  1. ICEfaces
  2. ICE-3140

selectOneRadio renders a table with default cell padding and spacing

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.7.1
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            any uses of selectOneRadio

            Description

            The selectOneRadio renderer uses a HTML table element to layout its child components. The table element does not specify either cellpadding or cellspacing attributes which make styling the component difficult. Both cellpadding and cellspacing default to 1px which means that the selectOneRadio component will be offset as much as 4px in the vertical with any label on the same plain.

            I recommend that the cellpading and cellspacing attributes be set with initial values of zero. CSS can then be used by the end user to specify the equivalent L&F, no changes will be needed in our default themes as the end result of the renderer is favourable in our demo application.

              Issue Links

              is duplicated by

              Improvement - An improvement or enhancement to an existing feature or task. ICE-6689 CLONE -selectOneRadio renders a table with default cell padding and spacing

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Patrick Corless created issue -
                Patrick Corless made changes -
                Field Original Value New Value
                Fix Version/s 1.7.1 [ 10122 ]
                Assignee Ken Fyten [ ken.fyten ]
                Priority Major [ 3 ] Minor [ 4 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                In order to maintain complete backwards compatiblitiy with the existing rendering and component spacing we could add the padding back into our default theme style sheets so that we don't mess up any existing applications.

                The new rule would likely look like:

                .iceSelOneRb table tr td

                { padding: 1px; margin: 1px; }
                Show
                Ken Fyten added a comment - In order to maintain complete backwards compatiblitiy with the existing rendering and component spacing we could add the padding back into our default theme style sheets so that we don't mess up any existing applications. The new rule would likely look like: .iceSelOneRb table tr td { padding: 1px; margin: 1px; }
                Ken Fyten made changes -
                Assignee Priority P3
                Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
                made changes -
                Attachment screenshot-1.jpg [ 11044 ]
                Hide
                Permalink
                Patrick Corless added a comment -

                I suspect the margin: 1px maybe causing this. Can you confirm?

                Show
                Patrick Corless added a comment - I suspect the margin: 1px maybe causing this. Can you confirm?
                Hide
                Permalink
                yip.ng added a comment -

                The margin property doesn't seem to have any effect on the layout. I tried changing it to a large value, but the layout remained the same. Also, the default value was "0" in Firefox and "auto" in IE. So, if it is for backwards compatibility, we should probably just leave it out.

                Show
                yip.ng added a comment - The margin property doesn't seem to have any effect on the layout. I tried changing it to a large value, but the layout remained the same. Also, the default value was "0" in Firefox and "auto" in IE. So, if it is for backwards compatibility, we should probably just leave it out.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16816 Thu Jun 05 17:02:29 MDT 2008 yip.ng ICE-3140
                Set cellpadding and cellspacing of table containing radio buttons to "0".
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/RadioRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16817 Thu Jun 05 17:07:10 MDT 2008 yip.ng ICE-3140
                Set cellpadding and cellspacing of table containing radio buttons to "0".
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/RadioRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
                yip.ng made changes -
                Attachment screenshot-2.jpg [ 11047 ]
                yip.ng made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P3
                Assignee Yip Ng [ yip.ng ]
                Ken Fyten made changes -
                Link This issue is duplicated by ICE-6689 [ ICE-6689 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Patrick Corless
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: