ICEfaces
  1. ICEfaces
  2. ICE-2071

outputStyle under Facelets logs error messages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.2, 1.7DR#1, 1.7
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Win XP SP2, Firefox 2.0.0.6, JBoss 4.0.4, Facelets component-showcase
    • Workaround Exists:
      Yes
    • Workaround Description:
      Do not specify the "type" and "rel" attributes yourself.

      Description

      When I load the Facelets version of the component-showcase, I get the following message in my JBoss console:

      13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
      WARNING: /showcase-facelet.jspx @20,91 type="text/css" Property 'type' is not on type: com.icesoft.faces.component.style.OutputStyle
      13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
      WARNING: /showcase-facelet.jspx @20,91 rel="stylesheet" Property 'rel' is not on type: com.icesoft.faces.component.style.OutputStyle

      Basically, there are no "type" and "rel" attributes in outputStyle because they're rendered to hardcoded values. Specifying them is redundant and causes errors.

      We should make them proper attributes, in case someone needs to specify any other values, for whatever reason. Then, we should remove their use from our sample applications. This way, people looking at our code examples will see that they're unnecessary for the typical case, and people needing to override them will look in the TLD and see that it's possible.

        Activity

        Hide
        Arran McCullough added a comment -

        Rev 14833

        Removed 'type' and 'rel' attributed from outputStyle component for Address, Auction Monitor, and Component Showcase applications. All other samples didn't contain the outputStyle component.

        Show
        Arran McCullough added a comment - Rev 14833 Removed 'type' and 'rel' attributed from outputStyle component for Address, Auction Monitor, and Component Showcase applications. All other samples didn't contain the outputStyle component.
        Hide
        Adnan Durrani added a comment -

        Fix backported to 1.6 branch. revision 15034

        Show
        Adnan Durrani added a comment - Fix backported to 1.6 branch. revision 15034

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: