ICEfaces
  1. ICEfaces
  2. ICE-2071

outputStyle under Facelets logs error messages

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6.1
          • Fix Version/s: 1.6.2, 1.7DR#1, 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Win XP SP2, Firefox 2.0.0.6, JBoss 4.0.4, Facelets component-showcase
          • Workaround Exists:
            Yes
          • Workaround Description:
            Do not specify the "type" and "rel" attributes yourself.

            Description

            When I load the Facelets version of the component-showcase, I get the following message in my JBoss console:

            13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
            WARNING: /showcase-facelet.jspx @20,91 type="text/css" Property 'type' is not on type: com.icesoft.faces.component.style.OutputStyle
            13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
            WARNING: /showcase-facelet.jspx @20,91 rel="stylesheet" Property 'rel' is not on type: com.icesoft.faces.component.style.OutputStyle

            Basically, there are no "type" and "rel" attributes in outputStyle because they're rendered to hardcoded values. Specifying them is redundant and causes errors.

            We should make them proper attributes, in case someone needs to specify any other values, for whatever reason. Then, we should remove their use from our sample applications. This way, people looking at our code examples will see that they're unnecessary for the typical case, and people needing to override them will look in the TLD and see that it's possible.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Fix Version/s 1.7DR#1 [ 10100 ]
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Assignee Mark Collette [ mark.collette ] Arran McCullough [ amccullough ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14833 Wed Sep 19 13:59:38 MDT 2007 arran.mccullough ICE-2071: outputStyle under Facelets logs error messages

              Removed from Address, Auction Monitor, and Component Showcase applications.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/address-demo/web/response.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/address-demo/web/address.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/auctionMonitor.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/showcase.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/auctionControl.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/showcase-facelet.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/mobileChat.jspx
              Hide
              Permalink
              Arran McCullough added a comment -

              Rev 14833

              Removed 'type' and 'rel' attributed from outputStyle component for Address, Auction Monitor, and Component Showcase applications. All other samples didn't contain the outputStyle component.

              Show
              Arran McCullough added a comment - Rev 14833 Removed 'type' and 'rel' attributed from outputStyle component for Address, Auction Monitor, and Component Showcase applications. All other samples didn't contain the outputStyle component.
              Arran McCullough made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.6.2 [ 10111 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Assignee Arran McCullough [ amccullough ] Adnan Durrani [ adnan.durrani ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15034 Thu Oct 25 17:17:35 MDT 2007 adnan.durrani Backporting fix for ICE-2071 to 1.6 branch (outputStyle under Facelets logs error messages)
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/web/showcase-facelet.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/address-demo/web/address.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/mobileChat.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/address-demo/web/response.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/auctionControl.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/web/showcase.jspx
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/auctionMonitor.jspx
              Adnan Durrani made changes -
              Status Reopened [ 4 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Fix backported to 1.6 branch. revision 15034

              Show
              Adnan Durrani added a comment - Fix backported to 1.6 branch. revision 15034
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Fix Version/s 1.7DR#3 [ 10112 ]
              Resolution Fixed [ 1 ]
              Adnan Durrani made changes -
              Fix Version/s 1.7DR#3 [ 10112 ]
              Ken Fyten made changes -
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Adnan Durrani [ adnan.durrani ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: