Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.6.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Win XP SP2, Firefox 2.0.0.6, JBoss 4.0.4, Facelets component-showcase
-
Workaround Exists:Yes
-
Workaround Description:Do not specify the "type" and "rel" attributes yourself.
Description
When I load the Facelets version of the component-showcase, I get the following message in my JBoss console:
13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
WARNING: /showcase-facelet.jspx @20,91 type="text/css" Property 'type' is not on type: com.icesoft.faces.component.style.OutputStyle
13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
WARNING: /showcase-facelet.jspx @20,91 rel="stylesheet" Property 'rel' is not on type: com.icesoft.faces.component.style.OutputStyle
Basically, there are no "type" and "rel" attributes in outputStyle because they're rendered to hardcoded values. Specifying them is redundant and causes errors.
We should make them proper attributes, in case someone needs to specify any other values, for whatever reason. Then, we should remove their use from our sample applications. This way, people looking at our code examples will see that they're unnecessary for the typical case, and people needing to override them will look in the TLD and see that it's possible.
13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
WARNING: /showcase-facelet.jspx @20,91 type="text/css" Property 'type' is not on type: com.icesoft.faces.component.style.OutputStyle
13:54:51,328 ERROR [STDERR] 31-Aug-2007 1:54:51 PM com.sun.facelets.tag.jsf.ComponentRule warnAttr
WARNING: /showcase-facelet.jspx @20,91 rel="stylesheet" Property 'rel' is not on type: com.icesoft.faces.component.style.OutputStyle
Basically, there are no "type" and "rel" attributes in outputStyle because they're rendered to hardcoded values. Specifying them is redundant and causes errors.
We should make them proper attributes, in case someone needs to specify any other values, for whatever reason. Then, we should remove their use from our sample applications. This way, people looking at our code examples will see that they're unnecessary for the typical case, and people needing to override them will look in the TLD and see that it's possible.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15034 | Thu Oct 25 17:17:35 MDT 2007 | adnan.durrani | Backporting fix for |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/web/showcase-facelet.jspx
MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/address-demo/web/address.jspx MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/mobileChat.jspx MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/address-demo/web/response.jspx MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/auctionControl.jspx MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/web/showcase.jspx MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/auctionMonitor/web/auctionMonitor.jspx |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #14833 | Wed Sep 19 13:59:38 MDT 2007 | arran.mccullough | Removed from Address, Auction Monitor, and Component Showcase applications. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/samples/address-demo/web/response.jspx
MODIFY /icefaces/trunk/icefaces/samples/address-demo/web/address.jspx MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/auctionMonitor.jspx MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/showcase.jspx MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/auctionControl.jspx MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/showcase-facelet.jspx MODIFY /icefaces/trunk/icefaces/samples/auctionMonitor/web/mobileChat.jspx |