Details
-
Type:
Task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.2
-
Fix Version/s: 4.3
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ace yui
-
Assignee Priority:P2
Description
yui-checkboxbutton-button styleclasses on the enclosing span. Although I do not see any definition for yui-checkboxbutton-button applied, when you remove the definition for yui-button, it affects the position (and this really looks poor in checkboxButtons examples).
{code}
<span class="yui-button yui-checkboxbutton-button ui-button ui-widget"><span aria-disabled="false" class="first-child" role="checkbox"><button class="ui-corner-all ui-widget-content ice-checkboxbutton-checked" id="form:checkboxButtons:0_button" name="form:checkboxButtons:0_button" onfocus="ice.ace.evalInit(this);" tabindex="0" type="button"><span class="fa fa-check-square-o fa-lg"></span></button></span></span>
{code}
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
r51948: removed the rendering of yui style classes and adjusted the CSS rule definitions accordingly, for ace:checkboxButton and ace:checkboxButtons
Tested with ICEfaces 4 trunk r51969, Tomcat 8, MS Edge, Chrome 61, FF 47.
When the labels for the checkboxButtons are set to left or right the alignment is incorrect. The label appears to be about 40% lower than the checkboxButton it belongs to. This can be seen in the showcase demos ace:checkboxButtons > Label Position, Indicator Text and Required Styling. Please see attached screen shot bgAlignment.PNG which demonstrates radioButton and checkboxButtons label alignment side by side.
Alignment issue is also seen in QA tests for checkboxButton, checkboxButtons and buttonGroup and is present in all the tested browsers.
r51996: fixed alignment issue with labels by incorporating CSS rules from YUI into the component's CSS
r51997: removed YUI's button-core.css from being included in combined.css
note that neither in CheckboxButtonMeta or CheckboxButtonsMeta classes, the dependency for the yui classes are not defined. So in showcase app, since ace:tabSet is already present, the class will be present, but without this (non-showcase apps), the class will not be present. (perhaps QA can confirm in the checkboxButtons QA test?).