Details
-
Type:
Task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.2
-
Fix Version/s: 4.3
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ace yui
-
Assignee Priority:P2
Description
the current checkboxButton and checkboxButtons are rendering yui-button and
yui-checkboxbutton-button styleclasses on the enclosing span. Although I do not see any definition for yui-checkboxbutton-button applied, when you remove the definition for yui-button, it affects the position (and this really looks poor in checkboxButtons examples).
{code}
<span class="yui-button yui-checkboxbutton-button ui-button ui-widget"><span aria-disabled="false" class="first-child" role="checkbox"><button class="ui-corner-all ui-widget-content ice-checkboxbutton-checked" id="form:checkboxButtons:0_button" name="form:checkboxButtons:0_button" onfocus="ice.ace.evalInit(this);" tabindex="0" type="button"><span class="fa fa-check-square-o fa-lg"></span></button></span></span>
{code}
yui-checkboxbutton-button styleclasses on the enclosing span. Although I do not see any definition for yui-checkboxbutton-button applied, when you remove the definition for yui-button, it affects the position (and this really looks poor in checkboxButtons examples).
{code}
<span class="yui-button yui-checkboxbutton-button ui-button ui-widget"><span aria-disabled="false" class="first-child" role="checkbox"><button class="ui-corner-all ui-widget-content ice-checkboxbutton-checked" id="form:checkboxButtons:0_button" name="form:checkboxButtons:0_button" onfocus="ice.ace.evalInit(this);" tabindex="0" type="button"><span class="fa fa-check-square-o fa-lg"></span></button></span></span>
{code}
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 4.3 [ 13096 ] |
| Assignee | Arturo Zambrano [ artzambrano ] |
| Assignee Priority | P2 [ 10011 ] |
r51948: removed the rendering of yui style classes and adjusted the CSS rule definitions accordingly, for ace:checkboxButton and ace:checkboxButtons
Show
Arturo Zambrano
added a comment - r51948: removed the rendering of yui style classes and adjusted the CSS rule definitions accordingly, for ace:checkboxButton and ace:checkboxButtons
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #51948 | Tue Sep 26 15:04:45 MDT 2017 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbuttons/CheckboxButtonsRenderer.java
MODIFY
/icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java
MODIFY
/icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css
|
| Attachment | bgAlignment.PNG [ 22613 ] |
Tested with ICEfaces 4 trunk r51969, Tomcat 8, MS Edge, Chrome 61, FF 47.
When the labels for the checkboxButtons are set to left or right the alignment is incorrect. The label appears to be about 40% lower than the checkboxButton it belongs to. This can be seen in the showcase demos ace:checkboxButtons > Label Position, Indicator Text and Required Styling. Please see attached screen shot bgAlignment.PNG which demonstrates radioButton and checkboxButtons label alignment side by side.
Alignment issue is also seen in QA tests for checkboxButton, checkboxButtons and buttonGroup and is present in all the tested browsers.
Show
Liana Munroe
added a comment - Tested with ICEfaces 4 trunk r51969, Tomcat 8, MS Edge, Chrome 61, FF 47.
When the labels for the checkboxButtons are set to left or right the alignment is incorrect. The label appears to be about 40% lower than the checkboxButton it belongs to. This can be seen in the showcase demos ace:checkboxButtons > Label Position, Indicator Text and Required Styling. Please see attached screen shot bgAlignment.PNG which demonstrates radioButton and checkboxButtons label alignment side by side.
Alignment issue is also seen in QA tests for checkboxButton, checkboxButtons and buttonGroup and is present in all the tested browsers.
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
r51996: fixed alignment issue with labels by incorporating CSS rules from YUI into the component's CSS
Show
Arturo Zambrano
added a comment - r51996: fixed alignment issue with labels by incorporating CSS rules from YUI into the component's CSS
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #51996 | Thu Oct 05 15:53:13 MDT 2017 | art.zambrano | |
| Files Changed | ||||
|
MODIFY
/icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css
|
r51997: removed YUI's button-core.css from being included in combined.css
Show
Arturo Zambrano
added a comment - r51997: removed YUI's button-core.css from being included in combined.css
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #51997 | Thu Oct 05 17:56:53 MDT 2017 | art.zambrano | |
| Files Changed | ||||
|
MODIFY
/icefaces4/trunk/icefaces/ace/component/build.xml
|
| Status | Resolved [ 5 ] | Closed [ 6 ] |
note that neither in CheckboxButtonMeta or CheckboxButtonsMeta classes, the dependency for the yui classes are not defined. So in showcase app, since ace:tabSet is already present, the class will be present, but without this (non-showcase apps), the class will not be present. (perhaps QA can confirm in the checkboxButtons QA test?).