ICEfaces
  1. ICEfaces
  2. ICE-11333

replace and remove yui-button style class definitions from ace:checkboxButton

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ace yui
    • Assignee Priority:
      P2

      Description

      the current checkboxButton and checkboxButtons are rendering yui-button and
      yui-checkboxbutton-button styleclasses on the enclosing span. Although I do not see any definition for yui-checkboxbutton-button applied, when you remove the definition for yui-button, it affects the position (and this really looks poor in checkboxButtons examples).

      {code}
      <span class="yui-button yui-checkboxbutton-button ui-button ui-widget"><span aria-disabled="false" class="first-child" role="checkbox"><button class="ui-corner-all ui-widget-content ice-checkboxbutton-checked" id="form:checkboxButtons:0_button" name="form:checkboxButtons:0_button" onfocus="ice.ace.evalInit(this);" tabindex="0" type="button"><span class="fa fa-check-square-o fa-lg"></span></button></span></span>
      {code}

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51997 Thu Oct 05 17:56:53 MDT 2017 art.zambrano ICE-11333 removed YUI's button-core.css from being included in combined.css
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51996 Thu Oct 05 15:53:13 MDT 2017 art.zambrano ICE-11333 fixed alignment issue with labels by incorporating CSS rules from YUI into the component's CSS
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51948 Tue Sep 26 15:04:45 MDT 2017 art.zambrano ICE-11333 removed the rendering of yui style classes and adjusted the CSS rule definitions accordingly, for ace:checkboxButton and ace:checkboxButtons
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbuttons/CheckboxButtonsRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: