ICEfaces
  1. ICEfaces
  2. ICE-11072

JS console errors are seen with ace:comboBox when toggling the disabled or readonly attributes to true.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.1.0.RC1
    • Fix Version/s: 4.2.BETA, 4.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4 trunk r48859
      Tomcat 8, all browsers
    • Assignee Priority:
      P2

      Description

      JS console errors are seen when toggling the disabled and readonly attributes to true in the comboBox dynamic attribute test application.
      TypeError: this.hidden is undefined
      http://localhost:8080/comboBox/javax.faces.resource/combobox/combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_160526
      Line 37

      To reproduce:
      1.) Use the /comboBoxDynAttribute.jsf application located at:
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
      2.) Select the rendered checkbox.
      3.) Select either the disabled or readOnly checkboxes. Console error will be shown.




        Activity

        Hide
        Mircea Toma added a comment -

        Modified hidden input text element lookup to actually find the element. Previously a jQuery selector was used for finding an input[type=hidden] element which is not rendered anymore by ComboBoxRenderer.

        Show
        Mircea Toma added a comment - Modified hidden input text element lookup to actually find the element. Previously a jQuery selector was used for finding an input [type=hidden] element which is not rendered anymore by ComboBoxRenderer.
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces 4 trunk r49532, Tomcat 8, FF 47, Chrome 53, IE 11.
        The original console error is resolved however there is a new console error seen when interacting with the comboBox drop arrow after setting the disabled or readOnly attributes to true. Also the comboBox does not appear disabled when that attribute is true.

        Uncaught TypeError: Cannot read property 'length' of undefined(…)
        combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_161109:33 
        

        To reproduce:
        1.) Use the /comboBoxDynAttribute.jsf application located at:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
        2.) Select the rendered checkbox.
        3.) Select either the disabled or readOnly checkboxes.
        4.) On the rendered comboBox click the down arrow on the right side of the component. At this point the console error appears.

        Show
        Liana Munroe added a comment - Tested with ICEfaces 4 trunk r49532, Tomcat 8, FF 47, Chrome 53, IE 11. The original console error is resolved however there is a new console error seen when interacting with the comboBox drop arrow after setting the disabled or readOnly attributes to true. Also the comboBox does not appear disabled when that attribute is true. Uncaught TypeError: Cannot read property 'length' of undefined(…) combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_161109:33 To reproduce: 1.) Use the /comboBoxDynAttribute.jsf application located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox 2.) Select the rendered checkbox. 3.) Select either the disabled or readOnly checkboxes. 4.) On the rendered comboBox click the down arrow on the right side of the component. At this point the console error appears.
        Hide
        Mircea Toma added a comment -

        This last issue is not a regression introduced by the previous commit. It is just another issue with the comboBox, orthogonal to the previous issue.

        The applied fix modifies the body of clientSideModeUpdate function to execute only when there's a client side configuration defined.

        Show
        Mircea Toma added a comment - This last issue is not a regression introduced by the previous commit. It is just another issue with the comboBox, orthogonal to the previous issue. The applied fix modifies the body of clientSideModeUpdate function to execute only when there's a client side configuration defined.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r49534, Tomcat 8, MS edge, IE 11, 10, 9, 8, FF 47, Chrome 53.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r49534, Tomcat 8, MS edge, IE 11, 10, 9, 8, FF 47, Chrome 53.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Liana Munroe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: