ICEfaces
  1. ICEfaces
  2. ICE-11072

JS console errors are seen with ace:comboBox when toggling the disabled or readonly attributes to true.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.1.0.RC1
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 4 trunk r48859
            Tomcat 8, all browsers
          • Assignee Priority:
            P2

            Description

            JS console errors are seen when toggling the disabled and readonly attributes to true in the comboBox dynamic attribute test application.
            TypeError: this.hidden is undefined
            http://localhost:8080/comboBox/javax.faces.resource/combobox/combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_160526
            Line 37

            To reproduce:
            1.) Use the /comboBoxDynAttribute.jsf application located at:
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
            2.) Select the rendered checkbox.
            3.) Select either the disabled or readOnly checkboxes. Console error will be shown.




              Activity

              Descending order - Click to sort in ascending order
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r49534, Tomcat 8, MS edge, IE 11, 10, 9, 8, FF 47, Chrome 53.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r49534, Tomcat 8, MS edge, IE 11, 10, 9, 8, FF 47, Chrome 53.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49534 Thu Nov 10 07:48:36 MST 2016 mircea.toma ICE-11072 Render panel's markup as invisible right away, without waiting for the JS init component code to hide it.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/notificationpanel/NotificationPanelRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49533 Wed Nov 09 18:19:44 MST 2016 mircea.toma ICE-11072 Execute body clientSideModeUpdate function only when there's a clientSideModeCfg defined.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/combobox/combobox.js
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              This last issue is not a regression introduced by the previous commit. It is just another issue with the comboBox, orthogonal to the previous issue.

              The applied fix modifies the body of clientSideModeUpdate function to execute only when there's a client side configuration defined.

              Show
              Mircea Toma added a comment - This last issue is not a regression introduced by the previous commit. It is just another issue with the comboBox, orthogonal to the previous issue. The applied fix modifies the body of clientSideModeUpdate function to execute only when there's a client side configuration defined.
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r49532, Tomcat 8, FF 47, Chrome 53, IE 11.
              The original console error is resolved however there is a new console error seen when interacting with the comboBox drop arrow after setting the disabled or readOnly attributes to true. Also the comboBox does not appear disabled when that attribute is true.

              Uncaught TypeError: Cannot read property 'length' of undefined(…)
combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_161109:33

              To reproduce:
              1.) Use the /comboBoxDynAttribute.jsf application located at:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
              2.) Select the rendered checkbox.
              3.) Select either the disabled or readOnly checkboxes.
              4.) On the rendered comboBox click the down arrow on the right side of the component. At this point the console error appears.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r49532, Tomcat 8, FF 47, Chrome 53, IE 11. The original console error is resolved however there is a new console error seen when interacting with the comboBox drop arrow after setting the disabled or readOnly attributes to true. Also the comboBox does not appear disabled when that attribute is true. Uncaught TypeError: Cannot read property 'length' of undefined(…) combobox.c.js.jsf?ln=icefaces.ace&v=4_2_0_161109:33 To reproduce: 1.) Use the /comboBoxDynAttribute.jsf application located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox 2.) Select the rendered checkbox. 3.) Select either the disabled or readOnly checkboxes. 4.) On the rendered comboBox click the down arrow on the right side of the component. At this point the console error appears.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49532 Wed Nov 09 16:11:38 MST 2016 mircea.toma ICE-11072 Modified hidden input text element lookup to match the element.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/combobox/combobox.js
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified hidden input text element lookup to actually find the element. Previously a jQuery selector was used for finding an input[type=hidden] element which is not rendered anymore by ComboBoxRenderer.

              Show
              Mircea Toma added a comment - Modified hidden input text element lookup to actually find the element. Previously a jQuery selector was used for finding an input [type=hidden] element which is not rendered anymore by ComboBoxRenderer.
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Mircea Toma [ mircea.toma ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s 4.2 [ 12870 ]
              Liana Munroe made changes -
              Summary JS console errors are seen when toggling the disabled and readonly attributes to true. JS console errors are seen with ace:comboBox when toggling the disabled or readonly attributes to true.
              Liana Munroe made changes -
              Field Original Value New Value
              Summary JS console errors are seen when toggling the disabled and readonly attributes to true in the comboBox dynamic attribute test application. JS console errors are seen when toggling the disabled and readonly attributes to true.
              Liana Munroe created issue -

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: