ICEfaces
  1. ICEfaces
  2. ICE-10298

Consolidate common class between core, ace and mobi

          Details

          • Assignee Priority:
            P2

            Description

            While working on bridgeIt issue #44 I came across a a duplicate classes:

            svn\ossrepo\icefaces4\trunk\icefaces\core\src\main\java\org\icefaces\util\UserAgentInfo.java
            svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\UserAgentInfo.java

            while adding detection for iOS8.

            So dug little deeper and also noticed 13 common classes between the packages :

            svn\ossrepo\icefaces4\trunk\icefaces\ace\component\src\org\icefaces\ace\util\
            and
            svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\

            Interestingly enough some of these duplicate class have started to diverge. For example mobi has a outputStrem memory patch for Utilts.java while ace Utils.java doesn't.

            It would be a good time before final to move any common source the core and merge the divergent changes.

              Activity

              Hide
              Permalink
              Arturo Zambrano added a comment -

              Finished consolidating common classes between MOBI and ACE at revision 43098.

              • Removed duplicate UserAgentInfo class from MOBI and changed references to point to the one in CORE.
              • Removed 12 classes froom the util package under MOBI and changed references to those classes to point to their ACE counterparts, adding to the ACE classes whatever was necessary to add from the MOBI classes. These classes are: ARIA, ArrayUtils, Attribute, ComponentUtils, DeferredLocaleFacesMessage, JSONBuilder, PassThruAttributeWriter, ScriptWriter, HTML, Constants, MessageUtils, and Utils.
              • Removed SXUtils class from ACE, since it's not used there.
              Show
              Arturo Zambrano added a comment - Finished consolidating common classes between MOBI and ACE at revision 43098. Removed duplicate UserAgentInfo class from MOBI and changed references to point to the one in CORE. Removed 12 classes froom the util package under MOBI and changed references to those classes to point to their ACE counterparts, adding to the ACE classes whatever was necessary to add from the MOBI classes. These classes are: ARIA, ArrayUtils, Attribute, ComponentUtils, DeferredLocaleFacesMessage, JSONBuilder, PassThruAttributeWriter, ScriptWriter, HTML, Constants, MessageUtils, and Utils. Removed SXUtils class from ACE, since it's not used there.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: