Details
-
Type: Task
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 4.0.BETA
-
Fix Version/s: 4.0
-
Component/s: ACE-Components, Framework, MOBI-Components
-
Labels:None
-
Environment:any
-
Assignee Priority:P2
Description
While working on bridgeIt issue #44 I came across a a duplicate classes:
svn\ossrepo\icefaces4\trunk\icefaces\core\src\main\java\org\icefaces\util\UserAgentInfo.java
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\UserAgentInfo.java
while adding detection for iOS8.
So dug little deeper and also noticed 13 common classes between the packages :
svn\ossrepo\icefaces4\trunk\icefaces\ace\component\src\org\icefaces\ace\util\
and
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\
Interestingly enough some of these duplicate class have started to diverge. For example mobi has a outputStrem memory patch for Utilts.java while ace Utils.java doesn't.
It would be a good time before final to move any common source the core and merge the divergent changes.
svn\ossrepo\icefaces4\trunk\icefaces\core\src\main\java\org\icefaces\util\UserAgentInfo.java
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\UserAgentInfo.java
while adding detection for iOS8.
So dug little deeper and also noticed 13 common classes between the packages :
svn\ossrepo\icefaces4\trunk\icefaces\ace\component\src\org\icefaces\ace\util\
and
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\
Interestingly enough some of these duplicate class have started to diverge. For example mobi has a outputStrem memory patch for Utilts.java while ace Utils.java doesn't.
It would be a good time before final to move any common source the core and merge the divergent changes.
Activity
Patrick Corless
created issue -
Patrick Corless
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee | Patrick Corless [ patrick.corless ] |
Patrick Corless
made changes -
Assignee | Patrick Corless [ patrick.corless ] | Ken Fyten [ ken.fyten ] |
Ken Fyten
made changes -
Assignee | Ken Fyten [ ken.fyten ] | Arturo Zambrano [ artzambrano ] |
Fix Version/s | 4.0 [ 11382 ] | |
Assignee Priority | P2 [ 10011 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #42708 | Tue Oct 07 18:25:38 MDT 2014 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java
MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Utils.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/UserAgentInfo.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #43090 | Thu Oct 23 11:57:17 MDT 2014 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/HTML.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #43094 | Thu Oct 23 13:33:02 MDT 2014 | art.zambrano | |
Files Changed | ||||
DEL
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/JSONBuilder.java
MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ScriptWriter.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #43095 | Thu Oct 23 13:40:51 MDT 2014 | art.zambrano | |
Files Changed | ||||
DEL
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/MessageUtils.java
DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/DeferredLocaleFacesMessage.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #43096 | Thu Oct 23 14:20:49 MDT 2014 | art.zambrano | |
Files Changed | ||||
DEL
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Constants.java
MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/SXUtils.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/Constants.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Utils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/BaseCoreRenderer.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #43097 | Thu Oct 23 14:39:17 MDT 2014 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/SXUtils.java
DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/SXUtils.java |
Arturo Zambrano
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Finished consolidating common classes between MOBI and ACE at revision 43098.