[ICE-10298] Consolidate common class between core, ace and mobi - ICEsoft JIRA Issue Tracker

Details

Type: Task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.BETA
Fix Version/s: 4.0
Component/s: ACE-Components, Framework, MOBI-Components
Labels:
None
Environment:
any

Assignee Priority:
P2

Description

While working on bridgeIt issue #44 I came across a a duplicate classes:

svn\ossrepo\icefaces4\trunk\icefaces\core\src\main\java\org\icefaces\util\UserAgentInfo.java
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\UserAgentInfo.java

while adding detection for iOS8.

So dug little deeper and also noticed 13 common classes between the packages :

svn\ossrepo\icefaces4\trunk\icefaces\ace\component\src\org\icefaces\ace\util\
and
svn\ossrepo\icefaces4\trunk\icefaces\mobi\component\src\org\icefaces\mobi\util\

Interestingly enough some of these duplicate class have started to diverge. For example mobi has a outputStrem memory patch for Utilts.java while ace Utils.java doesn't.

It would be a good time before final to move any common source the core and merge the divergent changes.

Activity

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43098	Thu Oct 23 15:15:18 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating Utils.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/augmentedreality/AugmentedRealityRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/camera/CameraRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Utils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/viewmanager/ViewManagerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/MobiJSFUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/SXUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/dataview/DataView.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/largeview/LargeViewRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/Utils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/smallview/SmallViewRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43097	Thu Oct 23 14:39:17 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating SXUtils.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/SXUtils.java DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/SXUtils.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43096	Thu Oct 23 14:20:49 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating Constants.java
				Files Changed
				DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Constants.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/SXUtils.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/Constants.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Utils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/BaseCoreRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43095	Thu Oct 23 13:40:51 MDT 2014	art.zambrano	~~ICE-10298~~ removed unused MessageUtils.java and DeferredLocaleFacesMessage.java from mobi
				Files Changed
				DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/MessageUtils.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/DeferredLocaleFacesMessage.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43094	Thu Oct 23 13:33:02 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating JSONBuilder.java, ScriptWriter.java
				Files Changed
				DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/JSONBuilder.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ScriptWriter.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43093	Thu Oct 23 13:11:10 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating Attribute.java, ComponentUtils.java and PassThruAttributeWriter.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/sms/SmsRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Attribute.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/dataview/DataViewRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanel.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ComponentUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/PassThruAttributeWriter.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43092	Thu Oct 23 12:47:28 MDT 2014	art.zambrano	~~ICE-10298~~ reverting previous change, as there is a better way to consolidate these classes
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanel.java ADD /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ComponentUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java ADD /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/PassThruAttributeWriter.java ADD /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Attribute.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43091	Thu Oct 23 12:23:55 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating Attribute.java, ComponentUtils.java and PassThruAttributeWriter.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanel.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ComponentUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/PassThruAttributeWriter.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Attribute.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43090	Thu Oct 23 11:57:17 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating ARIA.java, ArrayUtils.java and HTML.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/HTML.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#43089	Thu Oct 23 11:38:58 MDT 2014	art.zambrano	~~ICE-10298~~ consolidating ARIA.java, ArrayUtils.java and HTML.java
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/fieldset/FieldSetRowRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/augmentedreality/AugmentedRealityRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/microphone/MicrophoneRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/viewmanager/ViewManagerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/BaseCoreRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/geolocation/GeolocationRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/outputlist/OutputListRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/fieldset/FieldSetGroupRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/fetchcontact/FetchContactRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/cloudpush/CloudPushRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/HTML.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ArrayUtils.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/sms/SmsRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/outputlist/OutputListItemsRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/ARIA.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/camera/CameraRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/geotrack/GeoTrackRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/thumbnail/ThumbnailRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/ContactListCoreRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/dataview/DataViewRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/outputlist/OutputListItemRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/camcorder/CamcorderRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/scan/ScanRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/viewmanager/ViewRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#42708	Tue Oct 07 18:25:38 MDT 2014	art.zambrano	~~ICE-10298~~ removed duplicate UserAgentInfo class
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/Utils.java DEL /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/util/UserAgentInfo.java

Consolidate common class between core, ace and mobi

Details

Description

Activity

People

Dates