ICEpush
  1. ICEpush
  2. PUSH-385

bridgeit.createPushId() failing when ice.browser.id cannot be found

    Details

      Description

      Currently the Cloud Push demo at http://bridgeit.mobi/demo/ is failing.

      1. Navigate to http://bridgeit.mobi/demo/
      2. Click on the 'Cloud Push' menu item

      The browser will stick at this point. A javascript error coming from bridgeit.createPushId() stops the navigation.

      VM338:861 Uncaught Cannot find value for cookie: ice.push.browser(anonymous function) @ VM338:861(anonymous function) @ VM338:466(anonymous function) @ VM338:70lookupCookieValue @ VM338:858(anonymous function) @ VM338:2929withNewQuery @ VM338:1007(anonymous function) @ VM338:1058(anonymous function) @ VM338:65namespace.push.createPushId @ VM338:2928addPushListenerImpl @ bridgeit.js:889(anonymous function) @ bridgeit.js:1687Promiz.resolve.thePromiz.then @ bridgeit.js:998b.addPushListener @ bridgeit.js:1686(anonymous function) @ VM444:105(anonymous function) @ jquery-1.9.1.min.js:3b.extend.globalEval @ jquery-1.9.1.min.js:3b.fn.extend.domManip @ jquery-1.9.1.min.js:4b.fn.extend.append @ jquery-1.9.1.min.js:4b.fn.(anonymous function) @ jquery-1.9.1.min.js:4a.mobile.allowCrossDomainPages.n.isSameDomain.a.ajax.success @ jquery.mobile-1.3.2.min.js:3c @ jquery-1.9.1.min.js:3p.fireWith @ jquery-1.9.1.min.js:3k @ jquery-1.9.1.min.js:5r @ jquery-1.9.1.min.js:5
      2015-12-09 10:44:45.535 VM338:1824 [icepush.f3b13.pushid-expiry] [Wed, 09 Dec 2015 14:44:45 GMT] stopped monitoring for unused pushIDs

      No other errors are seen in the logs and the push heartbeat seems to be running fine. The ice.push.browser value is in localstorage, but not in a cookie where icepush is currently looking for it.

      There has been some recent work done in the icepush javascript code around this, which might be involved.

      ICE-10753 rev. 45766

      The demo is pointing to api.bridgeit.mobi/push, which has recently been updated, although I'm not sure of the exact version or what icepush revision that corresponds to.

      We're also not sure exactly when the demo stopped working, but this was first noticed on Nov 25, 2015.

        Activity

        Hide
        Mircea Toma added a comment -

        Modified ice.push.createPushId function to avoid throwing an exception when the browser ID cookie is missing. Also fixed result callback invocation to have the callback invoked only when a push ID is returned.

        Show
        Mircea Toma added a comment - Modified ice.push.createPushId function to avoid throwing an exception when the browser ID cookie is missing. Also fixed result callback invocation to have the callback invoked only when a push ID is returned.
        Hide
        Ken Fyten added a comment -

        Re-opened to backport to the 3.3 maintenance branch.

        Show
        Ken Fyten added a comment - Re-opened to backport to the 3.3 maintenance branch.
        Hide
        Mircea Toma added a comment -

        Applied fix to maintenance branch.

        Show
        Mircea Toma added a comment - Applied fix to maintenance branch.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: