ICEpush
  1. ICEpush
  2. PUSH-378

Replace Cloud Push Notification support with the new Cloud Notification Service libraries

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, 4.1
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: Push Server
    • Labels:
      None
    • Environment:
      ICEpush, ICEpush-EE, EPS, Cloud Notification Service

      Description

      With the introduction of the Cloud Notification Service for the BridgeIt Services all the ICEpush layers, including ICEpush, ICEpush-EE and EPS, should adapt to using the libraries of the Cloud Notification Service instead to avoid code duplication.

      This work includes crafting meaningful libraries (.jar files) in the Cloud Notification Service that can be used and the various ICEpush layers. Keeping open source and closed source code in mind.

      Finally, the old Notification Provider support should be removed from the various ICEpush layers.

        Activity

        Hide
        Jack Van Ooststroom added a comment -

        Corrected some names.

        Show
        Jack Van Ooststroom added a comment - Corrected some names.
        Hide
        Jack Van Ooststroom added a comment -

        The following locations in Subversion have been added:

        • /ossrepo/iceutil/trunk/iceutil/ (containing ICEsoft Util classes)
        • /ossrepo/icenotify/trunk/icenotify/ (containing ICEsoft Notify classes)
        • /repo/icenotify-ee/trunk/icenotify-ee/ (containing ICEsoft Notify-EE classes)

        ICEpush uses svn:externals to add the following mappings:

        • /ossrepo/icepush/trunk/icepush/util/ -> /ossrepo/iceutil/trunk/iceutil/util/
        • /ossrepo/icepush/trunk/icepush/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/

        ICEpush-EE uses svn:externals to add the following mappings:

        • /repo/icepush-ee/trunk/icepush-ee/util/ -> /ossrepo/iceutil/trunk/iceutil/util/
        • /repo/icepush-ee/trunk/icepush-ee/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/
        • /repo/icepush-ee/trunk/icepush-ee/cloud-ee/ -> /repo/icenotify-ee/trunk/icenotify-ee/cloud-ee/

        The Ant builds have been modified to include these. The end result is still a single icepush.jar that can be included in the applications.

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - The following locations in Subversion have been added: /ossrepo/iceutil/trunk/iceutil/ (containing ICEsoft Util classes) /ossrepo/icenotify/trunk/icenotify/ (containing ICEsoft Notify classes) /repo/icenotify-ee/trunk/icenotify-ee/ (containing ICEsoft Notify-EE classes) ICEpush uses svn:externals to add the following mappings: /ossrepo/icepush/trunk/icepush/util/ -> /ossrepo/iceutil/trunk/iceutil/util/ /ossrepo/icepush/trunk/icepush/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/ ICEpush-EE uses svn:externals to add the following mappings: /repo/icepush-ee/trunk/icepush-ee/util/ -> /ossrepo/iceutil/trunk/iceutil/util/ /repo/icepush-ee/trunk/icepush-ee/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/ /repo/icepush-ee/trunk/icepush-ee/cloud-ee/ -> /repo/icenotify-ee/trunk/icenotify-ee/cloud-ee/ The Ant builds have been modified to include these. The end result is still a single icepush.jar that can be included in the applications. Marking this one as FIXED.
        Hide
        Ken Fyten added a comment - - edited

        Found a regression in the icepush ant build for icefaces4/trunk.

        If you do an "ant world" in the icefaces dir, it builds successfully the first time. If you do a subsequent "ant world" build it fails with:

        " /Users/Ken/Code/svn/icefaces4-trunk/icefaces/icepush/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java:18: error: package org.icesoft.util does not exist
        [javac] import static org.icesoft.util.PreCondition.checkIfIsNotNull;"

        Note that using "ant allclean world" works everytime. I also confirmed that this issue did not exist in ICEfaces 4.0. Likely related to recent build changes.

        Show
        Ken Fyten added a comment - - edited Found a regression in the icepush ant build for icefaces4/trunk. If you do an "ant world" in the icefaces dir, it builds successfully the first time. If you do a subsequent "ant world" build it fails with: " /Users/Ken/Code/svn/icefaces4-trunk/icefaces/icepush/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java:18: error: package org.icesoft.util does not exist [javac] import static org.icesoft.util.PreCondition.checkIfIsNotNull;" Note that using "ant allclean world" works everytime. I also confirmed that this issue did not exist in ICEfaces 4.0. Likely related to recent build changes.
        Hide
        Jack Van Ooststroom added a comment -

        Sending build.xml
        Sending icepush/core/build.xml
        Transmitting file data ..
        Committed revision 48612.

        Show
        Jack Van Ooststroom added a comment - Sending build.xml Sending icepush/core/build.xml Transmitting file data .. Committed revision 48612.
        Hide
        Jack Van Ooststroom added a comment -

        The build issue of running "ant world" twice without invoking "ant allclean" has now been resolved. Marking this one as FIXED again.

        Show
        Jack Van Ooststroom added a comment - The build issue of running "ant world" twice without invoking "ant allclean" has now been resolved. Marking this one as FIXED again.

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: