ICEpush
  1. ICEpush
  2. PUSH-378

Replace Cloud Push Notification support with the new Cloud Notification Service libraries

          Details

          • Type: Improvement Improvement
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.0.0.GA, 4.1
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: Push Server
          • Labels:
            None
          • Environment:
            ICEpush, ICEpush-EE, EPS, Cloud Notification Service

            Description

            With the introduction of the Cloud Notification Service for the BridgeIt Services all the ICEpush layers, including ICEpush, ICEpush-EE and EPS, should adapt to using the libraries of the Cloud Notification Service instead to avoid code duplication.

            This work includes crafting meaningful libraries (.jar files) in the Cloud Notification Service that can be used and the various ICEpush layers. Keeping open source and closed source code in mind.

            Finally, the old Notification Provider support should be removed from the various ICEpush layers.

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Link This issue blocks NTFY-284 [ NTFY-284 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12172 ]
              Fix Version/s 4.2 [ 12871 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending build.properties
              Sending build.xml
              Transmitting file data ..
              Committed revision 44146.

              Show
              Jack Van Ooststroom added a comment - Sending build.properties Sending build.xml Transmitting file data .. Committed revision 44146.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Included iceutil, icenotify and icenotify-ee into icepush-ee using svn:externals and modified the Ant build to merge all of them into the single icepush-ee.jar.

              Show
              Jack Van Ooststroom added a comment - Included iceutil, icenotify and icenotify-ee into icepush-ee using svn:externals and modified the Ant build to merge all of them into the single icepush-ee.jar.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending build-common.xml
              Sending build.properties
              Sending build.xml
              Transmitting file data ...
              Committed revision 47028.

              Show
              Jack Van Ooststroom added a comment - Sending build-common.xml Sending build.properties Sending build.xml Transmitting file data ... Committed revision 47028.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Included iceutil and icenotify into icepush using svn:externals and modified the Ant build to merge all of them into the single icepush-ee.jar.

              Show
              Jack Van Ooststroom added a comment - Included iceutil and icenotify into icepush using svn:externals and modified the Ant build to merge all of them into the single icepush-ee.jar.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47028 Tue Jan 26 13:02:46 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/build-common.xml
              Commit graph MODIFY /icepush/trunk/icepush/build.xml
              Commit graph MODIFY /icepush/trunk/icepush/build.properties
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47029 Tue Jan 26 13:14:55 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Forgot some additional libraries for ICEpush-EE:

              Adding (bin) lib/jackson-annotations-2.4.4.jar
              Adding (bin) lib/jackson-core-2.4.4.jar
              Adding (bin) lib/jackson-databind-2.4.4.jar
              Transmitting file data ...
              Committed revision 44150.

              Show
              Jack Van Ooststroom added a comment - Forgot some additional libraries for ICEpush-EE: Adding (bin) lib/jackson-annotations-2.4.4.jar Adding (bin) lib/jackson-core-2.4.4.jar Adding (bin) lib/jackson-databind-2.4.4.jar Transmitting file data ... Committed revision 44150.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending src/main/java/org/icepush/ConfirmationTimeout.java
              Deleting src/main/java/org/icepush/EmailNotificationProvider.java
              Sending src/main/java/org/icepush/LocalPushGroupManager.java
              Sending src/main/java/org/icepush/NoopPushGroupManager.java
              Deleting src/main/java/org/icepush/NotificationProvider.java
              Deleting src/main/java/org/icepush/OutOfBandNotifier.java
              Sending src/main/java/org/icepush/PushGroupManager.java
              Sending src/main/java/org/icepush/servlet/MainServlet.java
              Transmitting file data .....
              Committed revision 47031.

              Show
              Jack Van Ooststroom added a comment - Sending src/main/java/org/icepush/ConfirmationTimeout.java Deleting src/main/java/org/icepush/EmailNotificationProvider.java Sending src/main/java/org/icepush/LocalPushGroupManager.java Sending src/main/java/org/icepush/NoopPushGroupManager.java Deleting src/main/java/org/icepush/NotificationProvider.java Deleting src/main/java/org/icepush/OutOfBandNotifier.java Sending src/main/java/org/icepush/PushGroupManager.java Sending src/main/java/org/icepush/servlet/MainServlet.java Transmitting file data ..... Committed revision 47031.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              ICEpush has been modified to use the new ICEnotify now.

              Show
              Jack Van Ooststroom added a comment - ICEpush has been modified to use the new ICEnotify now.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47031 Tue Jan 26 14:21:58 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph DEL /icepush/trunk/icepush/core/src/main/java/org/icepush/NotificationProvider.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushGroupManager.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/MainServlet.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/NoopPushGroupManager.java
              Commit graph DEL /icepush/trunk/icepush/core/src/main/java/org/icepush/OutOfBandNotifier.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
              Commit graph DEL /icepush/trunk/icepush/core/src/main/java/org/icepush/EmailNotificationProvider.java
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Deleting core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/AmazonSNSNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/BPNSNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/GcmNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/LoggingNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/TwilioSMSNotificationProvider.java
              Deleting core-ee/src/main/java/com/icesoft/icepush/WNSNotificationProvider.java
              Sending eps/src/main/java/com/icesoft/push/DynamicPushGroupManager.java
              Sending eps/src/main/java/com/icesoft/push/RemotePushGroupManager.java
              Transmitting file data ..
              Committed revision 44154.

              Show
              Jack Van Ooststroom added a comment - Deleting core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/AmazonSNSNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/BPNSNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/GcmNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/LoggingNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/TwilioSMSNotificationProvider.java Deleting core-ee/src/main/java/com/icesoft/icepush/WNSNotificationProvider.java Sending eps/src/main/java/com/icesoft/push/DynamicPushGroupManager.java Sending eps/src/main/java/com/icesoft/push/RemotePushGroupManager.java Transmitting file data .. Committed revision 44154.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              ICEpush-EE has been modified to use the new ICEnotify-EE now.

              Show
              Jack Van Ooststroom added a comment - ICEpush-EE has been modified to use the new ICEnotify-EE now.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending build.xml
              Transmitting file data .
              Committed revision 47032.

              Show
              Jack Van Ooststroom added a comment - Sending build.xml Transmitting file data . Committed revision 47032.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              ICEfaces Ant build has been fixed.

              Show
              Jack Van Ooststroom added a comment - ICEfaces Ant build has been fixed.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47032 Tue Jan 26 16:13:03 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/build.xml
              Hide
              Permalink
              Carmen Cristurean added a comment -

              ICEfaces 4 trunk r. 47031/ Jenkins Build #1760/showcase:
              Errors occur when deploying showcase, auction, emporium apps on Tomcat 7.0.42; there are no errors if removing the icepush.jar from the .war file.
              The last working version was Jenkins # 1757.

              INFO: Deploying web application archive C:\Servers\apache-tomcat-7.0.42\webapps\showcase.war
              Jan 26, 2016 3:55:57 PM org.apache.catalina.core.ContainerBase addChildInternal
              SEVERE: ContainerBase.addChild: start:
              org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Catalina].StandardHost[localhost].Stan
              dardContext[/showcase]]
              at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
              at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
              at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
              at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)
              at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:983)
              at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1660)
              at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
              at java.util.concurrent.FutureTask.run(FutureTask.java:262)
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
              at java.lang.Thread.run(Thread.java:744)
              Caused by: java.lang.NoClassDefFoundError: javax/mail/internet/AddressException
              at java.lang.Class.getDeclaredFields0(Native Method)
              at java.lang.Class.privateGetDeclaredFields(Class.java:2397)
              at java.lang.Class.getDeclaredFields(Class.java:1806)
              ............

              Show
              Carmen Cristurean added a comment - ICEfaces 4 trunk r. 47031/ Jenkins Build #1760/showcase: Errors occur when deploying showcase, auction, emporium apps on Tomcat 7.0.42; there are no errors if removing the icepush.jar from the .war file. The last working version was Jenkins # 1757. INFO: Deploying web application archive C:\Servers\apache-tomcat-7.0.42\webapps\showcase.war Jan 26, 2016 3:55:57 PM org.apache.catalina.core.ContainerBase addChildInternal SEVERE: ContainerBase.addChild: start: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine [Catalina] .StandardHost [localhost] .Stan dardContext [/showcase] ] at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633) at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:983) at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1660) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) Caused by: java.lang.NoClassDefFoundError: javax/mail/internet/AddressException at java.lang.Class.getDeclaredFields0(Native Method) at java.lang.Class.privateGetDeclaredFields(Class.java:2397) at java.lang.Class.getDeclaredFields(Class.java:1806) ............
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The previous mentioned issue has been addressed in NTFY-341.

              Show
              Jack Van Ooststroom added a comment - The previous mentioned issue has been addressed in NTFY-341.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending pom.xml
              Adding icepush/cloud/pom.xml
              Sending icepush/core/pom.xml
              Sending icepush/pom.xml
              Adding icepush/util/pom.xml
              Transmitting file data .....
              Committed revision 47042.

              Show
              Jack Van Ooststroom added a comment - Sending pom.xml Adding icepush/cloud/pom.xml Sending icepush/core/pom.xml Sending icepush/pom.xml Adding icepush/util/pom.xml Transmitting file data ..... Committed revision 47042.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              First fixes for the Maven build. Next up is to incorporate the merging of iceutil.jar, icenotify.jar, and icepush.jar into a combined icepush.jar.

              Show
              Jack Van Ooststroom added a comment - First fixes for the Maven build. Next up is to incorporate the merging of iceutil.jar, icenotify.jar, and icepush.jar into a combined icepush.jar.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47042 Thu Jan 28 19:55:48 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph ADD /iceutil/trunk/iceutil/util/pom.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/pom.xml
              Commit graph MODIFY /icepush/trunk/icepush/pom.xml
              Commit graph MODIFY /icepush/trunk/icepush/core/pom.xml
              Commit graph ADD /icenotify/trunk/icenotify/cloud/pom.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #47043 Fri Jan 29 08:14:46 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries
              Files Changed
              Commit graph MODIFY /iceutil/trunk/iceutil/util/pom.xml
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/pom.xml
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending icepush/cloud/pom.xml
              Sending icepush/util/pom.xml
              Transmitting file data ..
              Committed revision 47043.

              Show
              Jack Van Ooststroom added a comment - Sending icepush/cloud/pom.xml Sending icepush/util/pom.xml Transmitting file data .. Committed revision 47043.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Corrected some names.

              Show
              Jack Van Ooststroom added a comment - Corrected some names.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The following locations in Subversion have been added:

              • /ossrepo/iceutil/trunk/iceutil/ (containing ICEsoft Util classes)
              • /ossrepo/icenotify/trunk/icenotify/ (containing ICEsoft Notify classes)
              • /repo/icenotify-ee/trunk/icenotify-ee/ (containing ICEsoft Notify-EE classes)

              ICEpush uses svn:externals to add the following mappings:

              • /ossrepo/icepush/trunk/icepush/util/ -> /ossrepo/iceutil/trunk/iceutil/util/
              • /ossrepo/icepush/trunk/icepush/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/

              ICEpush-EE uses svn:externals to add the following mappings:

              • /repo/icepush-ee/trunk/icepush-ee/util/ -> /ossrepo/iceutil/trunk/iceutil/util/
              • /repo/icepush-ee/trunk/icepush-ee/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/
              • /repo/icepush-ee/trunk/icepush-ee/cloud-ee/ -> /repo/icenotify-ee/trunk/icenotify-ee/cloud-ee/

              The Ant builds have been modified to include these. The end result is still a single icepush.jar that can be included in the applications.

              Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The following locations in Subversion have been added: /ossrepo/iceutil/trunk/iceutil/ (containing ICEsoft Util classes) /ossrepo/icenotify/trunk/icenotify/ (containing ICEsoft Notify classes) /repo/icenotify-ee/trunk/icenotify-ee/ (containing ICEsoft Notify-EE classes) ICEpush uses svn:externals to add the following mappings: /ossrepo/icepush/trunk/icepush/util/ -> /ossrepo/iceutil/trunk/iceutil/util/ /ossrepo/icepush/trunk/icepush/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/ ICEpush-EE uses svn:externals to add the following mappings: /repo/icepush-ee/trunk/icepush-ee/util/ -> /ossrepo/iceutil/trunk/iceutil/util/ /repo/icepush-ee/trunk/icepush-ee/cloud/ -> /ossrepo/icenotify/trunk/icenotify/cloud/ /repo/icepush-ee/trunk/icepush-ee/cloud-ee/ -> /repo/icenotify-ee/trunk/icenotify-ee/cloud-ee/ The Ant builds have been modified to include these. The end result is still a single icepush.jar that can be included in the applications. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              Found a regression in the icepush ant build for icefaces4/trunk.

              If you do an "ant world" in the icefaces dir, it builds successfully the first time. If you do a subsequent "ant world" build it fails with:

              " /Users/Ken/Code/svn/icefaces4-trunk/icefaces/icepush/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java:18: error: package org.icesoft.util does not exist
              [javac] import static org.icesoft.util.PreCondition.checkIfIsNotNull;"

              Note that using "ant allclean world" works everytime. I also confirmed that this issue did not exist in ICEfaces 4.0. Likely related to recent build changes.

              Show
              Ken Fyten added a comment - - edited Found a regression in the icepush ant build for icefaces4/trunk. If you do an "ant world" in the icefaces dir, it builds successfully the first time. If you do a subsequent "ant world" build it fails with: " /Users/Ken/Code/svn/icefaces4-trunk/icefaces/icepush/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java:18: error: package org.icesoft.util does not exist [javac] import static org.icesoft.util.PreCondition.checkIfIsNotNull;" Note that using "ant allclean world" works everytime. I also confirmed that this issue did not exist in ICEfaces 4.0. Likely related to recent build changes.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending build.xml
              Sending icepush/core/build.xml
              Transmitting file data ..
              Committed revision 48612.

              Show
              Jack Van Ooststroom added a comment - Sending build.xml Sending icepush/core/build.xml Transmitting file data .. Committed revision 48612.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The build issue of running "ant world" twice without invoking "ant allclean" has now been resolved. Marking this one as FIXED again.

              Show
              Jack Van Ooststroom added a comment - The build issue of running "ant world" twice without invoking "ant allclean" has now been resolved. Marking this one as FIXED again.
              Jack Van Ooststroom made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48612 Tue Apr 05 09:03:13 MDT 2016 jack.van.ooststroom Fixed JIRA PUSH-378 : Replace Cloud Push Notification support with the new Cloud Notification Service libraries; Running 'ant world' twice issue has now been fixed.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/build.xml
              Commit graph MODIFY /icepush/trunk/icepush/core/build.xml
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.BETA [ 13073 ]
              Fix Version/s 4.2 [ 12871 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.1.BETA [ 13077 ]
              Fix Version/s EE-4.1.0.GA [ 12172 ]
              Fix Version/s EE-4.1.0.RC1 [ 13073 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.2.0.GA [ 13074 ]
              Fix Version/s EE-4.1.1.BETA [ 13077 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50747 Mon Feb 27 10:09:06 MST 2017 jack.van.ooststroom Reverted PUSH-378 fixes to ICEfaces-layer
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/build.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50748 Mon Feb 27 10:09:42 MST 2017 jack.van.ooststroom Reverted PUSH-378 fixes to ICEfaces-layer
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/pom.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50749 Mon Feb 27 10:13:33 MST 2017 jack.van.ooststroom Reverted PUSH-378 fixes to ICEfaces-layer
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/build.xml

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: