ICEpush
  1. ICEpush
  2. PUSH-362

ice.pushid params not being cleaned up and growing in number

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02, EE-4.0.0.GA, EE-3.3.0.GA_P03
          • Fix Version/s: 4.1, EE-3.3.0.GA_P04
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            All
          • Assignee Priority:
            P1
          • Support Case References:
          • Workaround Exists:
            Yes
          • Workaround Description:
            Using a redirect navigation instead of a forward keeps a single ice.pushid param.

            Description

            In this scenario an ace:fileEntry component is included in a template used by two pages. When navigating from one page to another, new ice:pushid params are being added to the listen.icepush.xml calls. The old ones are not cleaned up and new ones are created.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case.

              Steps:

              • Load main.jsf
              • Note the ice.pushid params that are in the listen.icepush.xml calls.
              • Click the commandLink and navigate to page 2.
              • The previous ice.pushid param is still there and a new one is there as well.
              Show
              Arran Mccullough added a comment - Attached test case. Steps: Load main.jsf Note the ice.pushid params that are in the listen.icepush.xml calls. Click the commandLink and navigate to page 2. The previous ice.pushid param is still there and a new one is there as well.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13447ExampleWAR.zip [ 20084 ]
              Attachment Case13447Example.zip [ 20085 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Fix Version/s 4.1 [ 11570 ]
              Fix Version/s EE-3.3.0.GA_P04 [ 12271 ]
              Assignee Priority P2 [ 10011 ]
              Component/s Push Library [ 10044 ]
              Component/s Release [ 10046 ]
              Hide
              Permalink
              Arran Mccullough added a comment -

              The customer is reporting that backporting fixes from the following JIRA to the EE 3.3.0 code base has resolved the issue for them:

              http://jira.icesoft.org/browse/PUSH-260
              http://jira.icesoft.org/browse/PUSH-269
              http://jira.icesoft.org/browse/PUSH-343

              Show
              Arran Mccullough added a comment - The customer is reporting that backporting fixes from the following JIRA to the EE 3.3.0 code base has resolved the issue for them: http://jira.icesoft.org/browse/PUSH-260 http://jira.icesoft.org/browse/PUSH-269 http://jira.icesoft.org/browse/PUSH-343
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #45806 Wed Jul 29 17:49:48 MDT 2015 mircea.toma PUSH-362 Modified FileEntryFormSubmit listener to keep the generated pushID in the window scope to ensure that subsequent rendering phases wil not generate new IDs every time.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryFormSubmit.java
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Cleanup pushID used by the file entry component on iframe unload. Also modified FileEntryFormSubmit listener to keep the generated pushID in the window scope to ensure that subsequent rendering phases will not generate new IDs every time.

              Show
              Mircea Toma added a comment - - edited Cleanup pushID used by the file entry component on iframe unload. Also modified FileEntryFormSubmit listener to keep the generated pushID in the window scope to ensure that subsequent rendering phases will not generate new IDs every time.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              ICEfaces4 trunk/ EE-3.3.0-maintenance r45810: verified with attached test case in Chrome43, FF34; verified showcase > ace:fileEntry.

              Show
              Carmen Cristurean added a comment - - edited ICEfaces4 trunk/ EE-3.3.0-maintenance r45810: verified with attached test case in Chrome43, FF34; verified showcase > ace:fileEntry.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Ken Fyten made changes -
              Affects Version/s EE-3.3.0.GA_P02 [ 11370 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Back ported fix to 3.3.0 maintenance branch.

              Show
              Mircea Toma added a comment - Back ported fix to 3.3.0 maintenance branch.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified EE-3.3.0-maintenance branch r45846; icefaces-ee/patches/icefaces-ee-3.3.0_P02_ICE10088/icefaces r45846 with attached test case, Chrome43.

              Show
              Carmen Cristurean added a comment - Verified EE-3.3.0-maintenance branch r45846; icefaces-ee/patches/icefaces-ee-3.3.0_P02_ICE10088/icefaces r45846 with attached test case, Chrome43.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Mircea Toma [ mircea.toma ] Judy Guglielmin [ judy.guglielmin ]
              Ken Fyten made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Committed fix for Fedex 3.3.0_P03 branch.

              Show
              Mircea Toma added a comment - Committed fix for Fedex 3.3.0_P03 branch.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: