ICEfaces
  1. ICEfaces
  2. ICE-9812

ice:panelPopup with radioButtons which manage ice:inputTextArea cause missing end-element and rendering problems

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P01
          • Fix Version/s: EE-3.3.0.GA_P02
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            jsf2 compat components
          • Assignee Priority:
            P1
          • Salesforce Case Reference:

            Description

            see attached test case.
            to reproduce see test case and page:-
            12628/testMainWindow.jsf

            click on radio button "Other" which will set the rendered flag for inputTextArea to true, server log will show the following and popup gets mangled.

            Jan 31, 2014 5:27:26 PM org.icefaces.impl.context.DOMResponseWriter endElement
            WARNING: Missing end-element for: td[id="privateForm:pg3-3-0"] (path: #document -> html -> body -> table -> tr -> td -> form -> div -> div -> table -> tr -> td -> div -> table -> tbody -> tr -> td)
            Jan 31, 2014 5:27:26 PM org.icefaces.impl.context.DOMResponseWriter endElement
            WARNING: Missing end-element for: td[id="privateForm:pg3-5-0"] (path: #document -> html -> body -> table -> tr -> td -> form -> div -> div -> table -> tr -> td -> div -> table -> tbody -> tr -> td)

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Judy Guglielmin added a comment -

              test case

              Show
              Judy Guglielmin added a comment - test case
              Hide
              Permalink
              Judy Guglielmin added a comment -

              support case issue assigned to you for scheduling.

              Show
              Judy Guglielmin added a comment - support case issue assigned to you for scheduling.
              Hide
              Permalink
              Mircea Toma added a comment -

              The issue occurs when plain HTML markup is rendered by UIInstructions components. These can call ResponseWriter.startElement without its corresponding close. GridRender is using DOMContext which interferes now with the correct handling of the DOM cursor.
              The fix changes GridRenderer to avoid calling DOMContext.setCursorParent, letting DOMResponseWriter to keep track of the cursor.

              Show
              Mircea Toma added a comment - The issue occurs when plain HTML markup is rendered by UIInstructions components. These can call ResponseWriter.startElement without its corresponding close. GridRender is using DOMContext which interferes now with the correct handling of the DOM cursor. The fix changes GridRenderer to avoid calling DOMContext.setCursorParent, letting DOMResponseWriter to keep track of the cursor.
              Hide
              Permalink
              Liana Munroe added a comment -

              AuctionMonitor Layout is broken after revision #39920. See attached screenshot auctionMonitor.PNG

              Show
              Liana Munroe added a comment - AuctionMonitor Layout is broken after revision #39920. See attached screenshot auctionMonitor.PNG
              Hide
              Permalink
              Mircea Toma added a comment -

              Reverted change to GridRenderer, the cursor is set correctly on the TD element.

              The fix modifies DOMResponseWriter to avoid tracking unclosed tags for document elements that have not been created through ResponseWriter.startElement/endElement methods. Since compat components use DOMContext to create elements directly into the backing DOM it does not make sense to track unclosed tag state.

              Show
              Mircea Toma added a comment - Reverted change to GridRenderer, the cursor is set correctly on the TD element. The fix modifies DOMResponseWriter to avoid tracking unclosed tags for document elements that have not been created through ResponseWriter.startElement/endElement methods. Since compat components use DOMContext to create elements directly into the backing DOM it does not make sense to track unclosed tag state.
              Hide
              Permalink
              Liana Munroe added a comment -

              AuctionMonitor Layout verified fixed. Tomcat 6, 7, Icefaces ee-3.3.0, revision #40043.

              Show
              Liana Munroe added a comment - AuctionMonitor Layout verified fixed. Tomcat 6, 7, Icefaces ee-3.3.0, revision #40043.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: