[ICE-9812] ice:panelPopup with radioButtons which manage ice:inputTextArea cause missing end-element and rendering problems - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-3.3.0.GA_P01
Fix Version/s: EE-3.3.0.GA_P02
Component/s: ICE-Components
Labels:
None
Environment:
jsf2 compat components

Assignee Priority:
P1
Salesforce Case Reference:

Description

see attached test case.
to reproduce see test case and page:-
12628/testMainWindow.jsf

click on radio button "Other" which will set the rendered flag for inputTextArea to true, server log will show the following and popup gets mangled.

Jan 31, 2014 5:27:26 PM org.icefaces.impl.context.DOMResponseWriter endElement
WARNING: Missing end-element for: td[id="privateForm:pg3-3-0"] (path: #document -> html -> body -> table -> tr -> td -> form -> div -> div -> table -> tr -> td -> div -> table -> tbody -> tr -> td)
Jan 31, 2014 5:27:26 PM org.icefaces.impl.context.DOMResponseWriter endElement
WARNING: Missing end-element for: td[id="privateForm:pg3-5-0"] (path: #document -> html -> body -> table -> tr -> td -> form -> div -> div -> table -> tr -> td -> div -> table -> tbody -> tr -> td)

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
12629.zip

31/Jan/14 5:33 PM

14 kB

Judy Guglielmin
12628/.classpath 2 kB

12628/.project 1.0 kB

12628/.settings/.jsdtscope 0.5 kB

12628/.../org.eclipse.jdt.core.prefs 0.3 kB

12628/.../org.eclipse.wst.common.component 0.4 kB

12628/.../org.eclipse.wst.common.project.facet.core.prefs.xml 0.3 kB

12628/.../org.eclipse.wst.common.project.facet.core.xml 0.4 kB

12628/.../org.eclipse.wst.jsdt.ui.superType.container 0.0 kB

12628/.../org.eclipse.wst.jsdt.ui.superType.name 0.0 kB

12628/build/.../TestPopupController.class 4 kB

12628/build/.../test/TestPopupServlet.class 2 kB

12628/src/.../test/TestPopupController.java 3 kB

12628/src/com/.../test/TestPopupServlet.java 0.9 kB

12628/WebContent/index.jsp 0.1 kB

12628/WebContent/index.xhtml 1 kB

12628/WebContent/META-INF/MANIFEST.MF 0.0 kB

12628/WebContent/testMainWindow.xhtml 2 kB

12628/WebContent/testPopup.xhtml 2 kB

12628/WebContent/.../faces-config.xml 0.3 kB

12628/WebContent/WEB-INF/web.xml 3 kB

Download Zip
Show

12629.zip

31/Jan/14 5:33 PM

14 kB

Judy Guglielmin

auctionMonitor.PNG

21 kB

12/Feb/14 9:24 AM

Activity

Ascending order - Click to sort in descending order

Judy Guglielmin created issue - 31/Jan/14 5:29 PM

Judy Guglielmin made changes - 31/Jan/14 5:30 PM

Field	Original Value	New Value
Salesforce Case Reference		5007000000ZDvw0AAD

Hide

Permalink

Judy Guglielmin added a comment - 31/Jan/14 5:33 PM

test case

Show

Judy Guglielmin added a comment - 31/Jan/14 5:33 PM test case

Judy Guglielmin made changes - 31/Jan/14 5:33 PM

Attachment

12629.zip [ 16663 ]

Judy Guglielmin made changes - 03/Feb/14 11:29 AM

Salesforce Case Reference

5007000000ZDvw0AAD

Judy Guglielmin made changes - 03/Feb/14 11:29 AM

Salesforce Case Reference

5007000000ZDuuhAAD

Hide

Permalink

Judy Guglielmin added a comment - 03/Feb/14 11:29 AM

support case issue assigned to you for scheduling.

Show

Judy Guglielmin added a comment - 03/Feb/14 11:29 AM support case issue assigned to you for scheduling.

Judy Guglielmin made changes - 03/Feb/14 11:29 AM

Assignee

Ken Fyten [ ken.fyten ]

Ken Fyten made changes - 05/Feb/14 10:36 AM

Assignee	Ken Fyten [ ken.fyten ]	Arturo Zambrano [ artzambrano ]
Fix Version/s		EE-3.3.0.GA_P02 [ 11371 ]
Assignee Priority		P2 [ 10011 ]

Ken Fyten made changes - 06/Feb/14 4:18 PM

Assignee

Arturo Zambrano [ artzambrano ]

Mircea Toma [ mircea.toma ]

Hide

Permalink

Mircea Toma added a comment - 10/Feb/14 8:52 AM

The issue occurs when plain HTML markup is rendered by UIInstructions components. These can call ResponseWriter.startElement without its corresponding close. GridRender is using DOMContext which interferes now with the correct handling of the DOM cursor.
The fix changes GridRenderer to avoid calling DOMContext.setCursorParent, letting DOMResponseWriter to keep track of the cursor.

Show

Mircea Toma added a comment - 10/Feb/14 8:52 AM The issue occurs when plain HTML markup is rendered by UIInstructions components. These can call ResponseWriter.startElement without its corresponding close. GridRender is using DOMContext which interferes now with the correct handling of the DOM cursor. The fix changes GridRenderer to avoid calling DOMContext.setCursorParent, letting DOMResponseWriter to keep track of the cursor.

Mircea Toma made changes - 10/Feb/14 8:52 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 12/Feb/14 9:23 AM

AuctionMonitor Layout is broken after revision #39920. See attached screenshot auctionMonitor.PNG

Show

Liana Munroe added a comment - 12/Feb/14 9:23 AM AuctionMonitor Layout is broken after revision #39920. See attached screenshot auctionMonitor.PNG

Liana Munroe made changes - 12/Feb/14 9:23 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]
Security		Private [ 10001 ]

Liana Munroe made changes - 12/Feb/14 9:24 AM

Attachment

auctionMonitor.PNG [ 16678 ]

Ken Fyten made changes - 12/Feb/14 9:44 AM

Assignee Priority

P2 [ 10011 ]

P1 [ 10010 ]

Hide

Permalink

Mircea Toma added a comment - 17/Feb/14 6:35 AM

Reverted change to GridRenderer, the cursor is set correctly on the TD element.

The fix modifies DOMResponseWriter to avoid tracking unclosed tags for document elements that have not been created through ResponseWriter.startElement/endElement methods. Since compat components use DOMContext to create elements directly into the backing DOM it does not make sense to track unclosed tag state.

Show

Mircea Toma added a comment - 17/Feb/14 6:35 AM Reverted change to GridRenderer, the cursor is set correctly on the TD element. The fix modifies DOMResponseWriter to avoid tracking unclosed tags for document elements that have not been created through ResponseWriter.startElement/endElement methods. Since compat components use DOMContext to create elements directly into the backing DOM it does not make sense to track unclosed tag state.

Mircea Toma made changes - 17/Feb/14 6:35 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 18/Feb/14 1:37 PM

AuctionMonitor Layout verified fixed. Tomcat 6, 7, Icefaces ee-3.3.0, revision #40043.

Show

Liana Munroe added a comment - 18/Feb/14 1:37 PM AuctionMonitor Layout verified fixed. Tomcat 6, 7, Icefaces ee-3.3.0, revision #40043.

Ken Fyten made changes - 03/Apr/14 11:18 AM

Security

Private [ 10001 ]

Ken Fyten made changes - 14/Nov/14 5:42 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Judy Guglielmin

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

31/Jan/14 5:29 PM

Updated:

14/Nov/14 5:42 PM

Resolved:

17/Feb/14 6:35 AM